Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unit Tests for PlanToBasePose() and example code #268

Open
DavidB-CMU opened this issue Feb 12, 2016 · 2 comments
Open

Add Unit Tests for PlanToBasePose() and example code #268

DavidB-CMU opened this issue Feb 12, 2016 · 2 comments

Comments

@DavidB-CMU
Copy link
Contributor

Should SBPL be a required or optional dependency for HERBpy?

The example code uses PlanToBasePose() - how should I make a Unit Test for this if? If SBPL is a required dependency then it is easier.

@DavidB-CMU
Copy link
Contributor Author

Mike wrote:
I agree with this entirely. However, I think these tests should be on SBPLPlanner and live in prpy. We should add or_sbpl as a <test_depend> like we did for the other planners that we test in prpy

@mkoval
Copy link
Member

mkoval commented Feb 12, 2016

I suggest adding it as a <test_depend>. This is what we did for the other planners that are optional dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants