Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BiteSelection: display last selected mask #46

Open
amalnanavati opened this issue May 10, 2023 · 0 comments
Open

BiteSelection: display last selected mask #46

amalnanavati opened this issue May 10, 2023 · 0 comments
Assignees

Comments

@amalnanavati
Copy link
Contributor

Say the robot tries to acquire a bite and fails. The robot cannot attempt to acquire the same bite because food items may have shifted on the plate, and therefore the previously selected mask is no longer reliable. Therefore, when the user clicks "no, try again" the app must take them back to Bite Selection (current functionality).

However, it is also possible that the food items have not shifted, and the old mask is still valid. In this case, we should not require the user to click on the image again and wait for food segmentation to occur again. Therefore, bite selection should display the previously-detected masks by default, and only update them if the user clicks the image again.

Therefore, this issue encompasses the following:

  1. Store the most recent user point click on the image, as well as the detected masks, in global state. In other words, move the actionResult from local state to global state (and rename it appropriately).
  2. When the bite selection screen is rendered, it should display the masks in actionResult, if they exist.
  3. Note that if enough time has passed since the user last clicked on the image, they may forget where they clicked and therefore what part of the plate the masks refer to. Therefore, render an overlay onto the image to remind the user what point the masks correspond to. Below is one idea, but please consider multiple and choose the one that seems the most aesthetical pleasing and useable.

Screenshot 2023-05-10 at 1 22 39 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants