Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Responsiveness of Icons #126

Open
amalnanavati opened this issue Feb 20, 2024 · 0 comments
Open

Improve Responsiveness of Icons #126

amalnanavati opened this issue Feb 20, 2024 · 0 comments

Comments

@amalnanavati
Copy link
Contributor

Building off of this commit message.

Currently, the app's solution to scaling SVG icons within buttons is to pass in iconWidth and iconHeight which is hardcoded as a percentage of the overall screen width/height. However, this won't work well if we render components in a smaller part of the screen, e.g., what we do when customizing distance to mouth in a smaller modal. Hence, the more robust solution to responsiveness of icon size is to make both the width and height a percentage of the icon's flexbox parts (se the above-linked commit for an example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant