Skip to content

Commit ba0a803

Browse files
committed
Fix author tests with dzil
Add a perlcriticrc file which treats `use Moose` as `use strict; use warnings`. Add trusted POD for BUILD methods of Moose. These do not need to be documented as they are part of the Moose API: https://metacpan.org/dist/Moose/view/lib/Moose/Manual/Construction.pod#BUILD Signed-off-by: Wesley Schwengle <[email protected]>
1 parent 7ea329c commit ba0a803

File tree

5 files changed

+14
-4
lines changed

5 files changed

+14
-4
lines changed

.perlcriticrc

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
[TestingAndDebugging::RequireUseStrict]
2+
equivalent_modules = Moose Test::Net::SAML2
3+
4+
[TestingAndDebugging::RequireUseWarnings]
5+
equivalent_modules = Moose Test::Net::SAML2
6+

lib/Net/SAML2/Binding/Redirect.pm

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,10 @@ has 'sls_double_encoded_response' => (
129129
default => 0
130130
);
131131

132+
=for Pod::Coverage BUILD
133+
134+
=cut
135+
132136
sub BUILD {
133137
my $self = shift;
134138

lib/Net/SAML2/Protocol/ArtifactResolve.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package Net::SAML2::Protocol::ArtifactResolve;
2+
use Moose;
23
# VERSION
34

4-
use Moose;
55
use MooseX::Types::URI qw/ Uri /;
66
use URN::OASIS::SAML2 qw(:urn);
77

lib/Net/SAML2/Protocol/LogoutRequest.pm

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package Net::SAML2::Protocol::LogoutRequest;
2-
# VERSION
3-
42
use Moose;
3+
# VERSION
54
use MooseX::Types::Common::String qw/ NonEmptySimpleStr /;
65
use MooseX::Types::URI qw/ Uri /;
76
use Net::SAML2::XML::Util qw/ no_comments /;

lib/Net/SAML2/Types.pm

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
package Net::SAML2::Types;
2-
# VERSION
32
use warnings;
43
use strict;
54

5+
# VERSION
6+
67
# ABSTRACT: Custom Moose types for Net::SAML2
78

89
use Types::Serialiser;

0 commit comments

Comments
 (0)