Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dual list selector to use tree view component #5746

Open
mcoker opened this issue Jul 6, 2023 · 2 comments
Open

Refactor dual list selector to use tree view component #5746

mcoker opened this issue Jul 6, 2023 · 2 comments
Labels
Pinned Use to thwart stalebot

Comments

@mcoker
Copy link
Contributor

mcoker commented Jul 6, 2023

The end goal would be to update the dual list tree view to use the tree view component. AFAIK the reason dual list did not use the tree view component initially was due to the differences in visual presentation (and number of overrides that would be needed in the dual list selector to account for the differences) and that using a component in another component (outside of a simple drop-in use case) can tie the styling of the nested component to its markup. A good example of that is including .pf-c-title.pf-m-xl for the title in a component, and design wants to change the font-size of that title. Since the font-size is tied to the markup (class="pf-m-xl"), react can make the update to change the title class, but non-react users now require action to get the update and their titles will be inconsistent until they do, which can possibly be a breaking change.

For now, I think this issue should be as spike, and we

  • Identify the differences between tree view and the dual list selector's tree view
  • Create an issue in the design repo and collaborate with the goal of normalizing those differences so we can use the tree view as-is in the dual list selector without any overrides.
    • Since using it as-is probably isn't likely, try and identify any variations/overrides needed to support being able to drop the tree view component into the dual list selector without setting us up for breaking changes.

related design issue patternfly/patternfly-design#1274

@mcoker mcoker added the DevX label Jul 6, 2023
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jul 6, 2023
@nicolethoen nicolethoen added this to the Prioritized Backlog milestone Jul 14, 2023
@nicolethoen nicolethoen moved this from Needs triage to Backlog in PatternFly Issues Jul 14, 2023
@stale
Copy link

stale bot commented Sep 13, 2023

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 30 days if no further activity occurs.

@stale stale bot added the wontfix This will not be worked on label Sep 13, 2023
@mcoker mcoker removed the wontfix This will not be worked on label Sep 22, 2023
@srambach srambach modified the milestones: Prioritized Backlog, 2023.Q4 Sep 28, 2023
Copy link

stale bot commented Nov 29, 2023

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 30 days if no further activity occurs.

@stale stale bot added the wontfix This will not be worked on label Nov 29, 2023
@mcoker mcoker added the Pinned Use to thwart stalebot label Dec 4, 2023
@stale stale bot removed the wontfix This will not be worked on label Dec 4, 2023
@srambach srambach added the PF6 label Dec 4, 2023
@kmcfaul kmcfaul removed DevX labels Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pinned Use to thwart stalebot
Projects
Status: Backlog
Development

No branches or pull requests

5 participants