You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The end goal would be to update the dual list tree view to use the tree view component. AFAIK the reason dual list did not use the tree view component initially was due to the differences in visual presentation (and number of overrides that would be needed in the dual list selector to account for the differences) and that using a component in another component (outside of a simple drop-in use case) can tie the styling of the nested component to its markup. A good example of that is including .pf-c-title.pf-m-xl for the title in a component, and design wants to change the font-size of that title. Since the font-size is tied to the markup (class="pf-m-xl"), react can make the update to change the title class, but non-react users now require action to get the update and their titles will be inconsistent until they do, which can possibly be a breaking change.
For now, I think this issue should be as spike, and we
Identify the differences between tree view and the dual list selector's tree view
Create an issue in the design repo and collaborate with the goal of normalizing those differences so we can use the tree view as-is in the dual list selector without any overrides.
Since using it as-is probably isn't likely, try and identify any variations/overrides needed to support being able to drop the tree view component into the dual list selector without setting us up for breaking changes.
This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 30 days if no further activity occurs.
This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 30 days if no further activity occurs.
The end goal would be to update the dual list tree view to use the tree view component. AFAIK the reason dual list did not use the tree view component initially was due to the differences in visual presentation (and number of overrides that would be needed in the dual list selector to account for the differences) and that using a component in another component (outside of a simple drop-in use case) can tie the styling of the nested component to its markup. A good example of that is including
.pf-c-title.pf-m-xl
for the title in a component, and design wants to change the font-size of that title. Since the font-size is tied to the markup (class="pf-m-xl"
), react can make the update to change the title class, but non-react users now require action to get the update and their titles will be inconsistent until they do, which can possibly be a breaking change.For now, I think this issue should be as spike, and we
related design issue patternfly/patternfly-design#1274
The text was updated successfully, but these errors were encountered: