Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow args into grad_f for ULD #542

Open
lockwo opened this issue Dec 13, 2024 · 1 comment
Open

Allow args into grad_f for ULD #542

lockwo opened this issue Dec 13, 2024 · 1 comment

Comments

@lockwo
Copy link
Contributor

lockwo commented Dec 13, 2024

In the ULD drift term you provide the grad f, which is then called https://github.com/patrick-kidger/diffrax/blob/main/diffrax/_term.py#L966. It would be nice to be able to have that function also accept args as well beyond the differentiated input (e.g. grad_f(x, args) where args is just auxiliary information like is used in other areas). I can also curry the args in for my case, but it seems like in general most things allow args as input in diffrax, so I wanted to inquire about making this consistent.

@patrick-kidger
Copy link
Owner

@andyElking WDYT? I have vague memories of us discussing this but I may be misremembering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants