-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sendHistogramReport
is not an accurate name
#44
Comments
Changing makes definitely sense. Wdyt about |
Changes sendHistogramReport() to contributeToHistogram() and reportContributionForEvent() to contributeToHistogramOnEvent(). Functionality is otherwise unchanged. See issue #44.
Changes sendHistogramReport() to contributeToHistogram() and reportContributionForEvent() to contributeToHistogramOnEvent(). Functionality is otherwise unchanged. See issue #44.
(Leaving open for the array suggestion) |
Hi Alex and Yoav, thanks for selecting the better name for API functions. I just wanted to create a new issue with proposal to add the method that accepts multiple keys/values, but then I noticed that this issue left open for the array suggestion. The proposal is that browser sends multiple reports to ad tech side in one request when those request passed in one API method call. Our use case:
Benefits:
To preserve privacy:
Alex, what would be your thoughts about this proposal? |
Just found the next information about the batching: This is something that would work for us. The only concern for me is truncating to the 20 reports per batch, another proposed option with splitting bigger batches into few requests each with 20 reports max per one request looks better. Is there any information what is the status of this proposal? Will it be implemented? |
Hi @xottabut! Sorry for the delay in responding. Yes, as you saw, our current design involves consolidating/batching any contributions in a "batching scope" together into one report. We're still considering allowing an array to be passed to This batching plan is currently implemented in Chrome and available under an Origin Trial. You can find some developer documentation here (although I don't believe it discusses this batching): https://developer.chrome.com/docs/privacy-sandbox/private-aggregation/. You can also find some more discussion of the design here: #32. But basically, the limit of 20 came to mitigate the size increase that will be introduced with padding. However, we're definitely looking feedback on the design, for example about:
It sounds like if we moved from truncation to splitting the contributions into multiple reports each with 20 (or fewer) contributions, that would work for you -- is that correct? Can you also share more details around your specific use case? Thanks for the feedback! |
Hi @alexmturner , thank you very much for providing more details. Yes, splitting them into multiple batches instead of truncating would work for us. Based on the calculations you provided in #32 (~1.2 kB for 50 contributions and ~500 B for 20 contributions) having 50 contributions per one request instead of 20 would work better for us. Here I have another question: since report is scheduled to be sent with a delay, will there be any batching for reports that were created from different worklet executions (i.e. different ad events)?
Summarizing for our use case with X duration on a daily basis reports:
Anatolii |
I opened #70 to tackle the "should we accept an array of contributions" question. Otherwise, I think we can close this to avoid confusion, as the OP issue was resolved with #48 |
IIUC,
sendHistogramReport
doesn't in fact send a report, but queues up a (single) PAHistogramContribution.As such, we may want to consider renaming it, e.g. to
aggregateHistogramContribution
orappendHistogramContribution
.Aside: would it make sense to enable it to get an array of
PAHistogramContribution
s as input?The text was updated successfully, but these errors were encountered: