fix: resolve all linting errors and update CHANGELOG for v0.1.1

- Fix isinstance calls to use modern union syntax (dict | list)
- Simplify ternary operators where applicable
- Remove unused variables
- Add ruff ignore rules for test-specific warnings (S105, S106, A004)
- Add ignore rule for module name 'site' (A005)
- Fix unused parameter in render_table function
- Update CHANGELOG.md with v0.1.1 release notes (Homebrew support)

All 55 tests passing, all linting checks pass.

Author: sheeek

CHANGELOG.md

@@ -5,6 +5,22 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.1.1] - 2026-01-08
+
+### Added
+- **Homebrew installation support** via `pasogott/tap`
+  - Stable release installation: `brew install pasogott/tap/frappecli`
+  - HEAD installation option: `brew install --HEAD pasogott/tap/frappecli`
+- Automatic Homebrew tap notification workflow on new releases
+- Auto-update workflow in homebrew-tap for new releases
+
+### Changed
+- Updated README with Homebrew installation instructions (recommended method for macOS)
+- Improved installation documentation with stable vs HEAD options
+
+### Fixed
+- GitHub Actions CI dependency installation
+
 ## [0.1.0] - 2026-01-08
 
 ### Added
@@ -98,5 +114,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - [Repository](https://github.com/pasogott/frappecli)
 - [Issues](https://github.com/pasogott/frappecli/issues)
 - [Releases](https://github.com/pasogott/frappecli/releases)
+- [Homebrew Tap](https://github.com/pasogott/homebrew-tap)
 
+[0.1.1]: https://github.com/pasogott/frappecli/releases/tag/v0.1.1
 [0.1.0]: https://github.com/pasogott/frappecli/releases/tag/v0.1.0

pyproject.toml

@@ -89,12 +89,18 @@ ignore = [
 [tool.ruff.lint.per-file-ignores]
 "tests/**/*.py" = [
     "S101",    # assert allowed in tests
+    "S105",    # hardcoded passwords ok in tests
+    "S106",    # hardcoded passwords ok in tests
     "ARG",     # unused arguments ok in tests (fixtures)
     "PLR2004", # magic values ok in tests
+    "A004",    # shadowing builtins ok in tests
 ]
 "src/frappecli/cli.py" = [
     "T201",    # print allowed in CLI
 ]
+"src/frappecli/commands/site.py" = [
+    "A005",    # module name 'site' is intentional
+]
 
 [tool.ruff.lint.isort]
 known-first-party = ["frappecli"]

src/frappecli/client.py

@@ -86,7 +86,7 @@ def _build_url(self, path: str, params: dict[str, Any] | None = None) -> str:
             # Convert dict/list params to JSON strings for Frappe API
             encoded_params = {}
             for key, value in params.items():
-                if isinstance(value, (dict, list)):
+                if isinstance(value, dict | list):
                     # Serialize as JSON string
                     encoded_params[key] = json.dumps(value)
                 else:

src/frappecli/commands/files.py

@@ -53,11 +53,11 @@ def upload_file(
         # Open file and prepare multipart data
         with file_path.open("rb") as f:
             files = {"file": (file_path.name, f, "application/octet-stream")}
-            
+
             # Remove Content-Type header for multipart upload
             # requests will set it automatically with boundary
             original_content_type = client.session.headers.pop("Content-Type", None)
-            
+
             try:
                 # Use raw session request for multipart upload
                 response = client.session.post(
@@ -83,7 +83,7 @@ def upload_file(
                 error_msg = error_data.get("exception", response.text)
             except Exception:
                 error_msg = response.text
-            
+
             console.print(f"[red]✗ Upload failed (HTTP {response.status_code}):[/red]")
             console.print(f"[red]{error_msg}[/red]")
     except Exception as e:
@@ -155,7 +155,7 @@ def render_table(data: list[dict] | list[str] | dict) -> None:
         if isinstance(data, dict):
             # Response might be wrapped in a dict
             data = data.get("files", data.get("data", [data]))
-        
+
         if not data:
             console.print("[yellow]No files found[/yellow]")
             return
@@ -232,7 +232,7 @@ def bulk_upload(
 
     # Parse pattern - support both absolute and relative paths
     pattern_path = Path(pattern)
-    
+
     if pattern_path.is_absolute():
         # Absolute path with glob pattern
         base_dir = pattern_path.parent
@@ -241,12 +241,9 @@ def bulk_upload(
         # Relative path
         base_dir = Path.cwd()
         pattern_name = pattern
-    
+
     # Find files
-    if recursive:
-        files = list(base_dir.rglob(pattern_name))
-    else:
-        files = list(base_dir.glob(pattern_name))
+    files = list(base_dir.rglob(pattern_name)) if recursive else list(base_dir.glob(pattern_name))
 
     if not files:
         console.print(f"[yellow]No files found matching pattern: {pattern}[/yellow]")
@@ -282,7 +279,9 @@ def bulk_upload(
                         success += 1
                     else:
                         failed += 1
-                        console.print(f"[red]✗ Failed: {file_path.name} (HTTP {response.status_code})[/red]")
+                        console.print(
+                            f"[red]✗ Failed: {file_path.name} (HTTP {response.status_code})[/red]"
+                        )
 
                 except Exception as e:
                     failed += 1

src/frappecli/commands/reports.py

@@ -101,8 +101,8 @@ def execute_report(
                         for row in data:
                             all_fieldnames.update(row.keys())
                         fieldnames = sorted(all_fieldnames)
-                        
-                        writer = csv.DictWriter(f, fieldnames=fieldnames, extrasaction='ignore')
+
+                        writer = csv.DictWriter(f, fieldnames=fieldnames, extrasaction="ignore")
                         writer.writeheader()
                         writer.writerows(data)
             else:
@@ -145,7 +145,7 @@ def render_table(data: any) -> None:
         console.print(f"\n[bold cyan]Result from {method}:[/bold cyan]\n")
         if data is None:
             console.print("[yellow]No return value[/yellow]")
-        elif isinstance(data, (dict, list)):
+        elif isinstance(data, dict | list):
             console.print(json.dumps(data, indent=2))
         else:
             console.print(str(data))

src/frappecli/commands/site.py

@@ -205,7 +205,7 @@ def status(ctx: click.Context, detailed: bool) -> None:
 
     # Test connectivity by fetching doctypes count
     try:
-        result = client.post(
+        client.post(
             "/api/method/frappe.client.get_list",
             data={
                 "doctype": "DocType",
@@ -214,18 +214,18 @@ def status(ctx: click.Context, detailed: bool) -> None:
             },
         )
         is_reachable = True
-        doctype_count = len(result) if result else 0
     except Exception as e:
         is_reachable = False
         error_msg = str(e)
 
-    def render_table(data: dict | list) -> None:
+    def render_table(_data: dict | list) -> None:
+        """Render site status as table (data parameter unused but required by output_data)."""
         console.print("\n[bold cyan]Site Status[/bold cyan]\n")
 
         if is_reachable:
             console.print(f"[green]✓[/green] Site is reachable at: {client.base_url}")
-            console.print(f"[green]Status:[/green] Online")
-            
+            console.print("[green]Status:[/green] Online")
+
             if detailed:
                 console.print("\n[dim]Note: Version info not available via API[/dim]")
         else:

tests/test_client.py

@@ -7,7 +7,7 @@
 import responses
 from requests.exceptions import ConnectionError, Timeout
 
-from frappecli.client import FrappeClient, FrappeAPIError, FrappeConnectionError
+from frappecli.client import FrappeAPIError, FrappeClient, FrappeConnectionError
 
 
 @pytest.fixture
@@ -96,9 +96,7 @@ def test_put_request(self, client, api_responses):
             status=200,
         )
 
-        result = client.put(
-            "/api/resource/User/test@example.com", data={"enabled": 0}
-        )
+        result = client.put("/api/resource/User/test@example.com", data={"enabled": 0})
         assert result == api_responses["success_response"]["message"]
 
     @responses.activate
@@ -205,9 +203,7 @@ def test_connection_error(self, client):
     @responses.activate
     def test_timeout_error(self, client):
         """Test timeout error handling."""
-        responses.add(
-            responses.GET, "https://test.example.com/api/test", body=Timeout("Timeout")
-        )
+        responses.add(responses.GET, "https://test.example.com/api/test", body=Timeout("Timeout"))
 
         with pytest.raises(FrappeConnectionError, match="Request timed out"):
             client.get("/api/test")

tests/test_config.py

@@ -1,6 +1,5 @@
 """Tests for configuration management."""
 
-import os
 from pathlib import Path
 
 import pytest
@@ -56,7 +55,7 @@ def test_get_site_config(self, test_config_path):
         """Test retrieving site configuration."""
         config = Config(test_config_path)
         site_config = config.get_site_config("production")
-        
+
         assert site_config is not None
         assert site_config["url"] == "https://erp.example.com"
         assert site_config["api_key"] == "prod_key_123"
@@ -72,15 +71,15 @@ def test_get_default_site_config(self, test_config_path):
         """Test retrieving default site configuration."""
         config = Config(test_config_path)
         site_config = config.get_default_site_config()
-        
+
         assert site_config is not None
         assert site_config["url"] == "https://erp.example.com"
 
     def test_list_sites(self, test_config_path):
         """Test listing all configured sites."""
         config = Config(test_config_path)
         sites = config.list_sites()
-        
+
         assert len(sites) == 3
         assert "production" in sites
         assert "staging" in sites
@@ -94,18 +93,18 @@ def test_env_var_substitution(self, test_config_path, monkeypatch):
         """Test environment variable substitution."""
         monkeypatch.setenv("FRAPPE_STAGING_KEY", "staging_key_from_env")
         monkeypatch.setenv("FRAPPE_STAGING_SECRET", "staging_secret_from_env")
-        
+
         config = Config(test_config_path)
         site_config = config.get_site_config("staging")
-        
+
         assert site_config["api_key"] == "staging_key_from_env"
         assert site_config["api_secret"] == "staging_secret_from_env"
 
     def test_env_var_missing(self, test_config_path, monkeypatch):
         """Test missing environment variable."""
         monkeypatch.delenv("FRAPPE_STAGING_KEY", raising=False)
         monkeypatch.delenv("FRAPPE_STAGING_SECRET", raising=False)
-        
+
         config = Config(test_config_path)
         with pytest.raises(ConfigError, match="Environment variable.*not set"):
             config.get_site_config("staging")