Fix particle leapfrog example initialization data #1183
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The
particle_leapfrog
example was generating a compiler error in #910. I was able to reproduce this error with NVHPC 24.7.0/nvcc 12.5 on a Darwinvolta-x86
node. Turns out we can't capture aKokkos::Array
ofKokkos::Array
s as a reference inside device code. I changed this to a copy and the code compiles for me (up to an ICE inpoisson_package.cpp
I am unsure about)@fglines-nv This should fix the build error you encountered.
PR Checklist