Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix particle leapfrog example initialization data #1183

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

brryan
Copy link
Collaborator

@brryan brryan commented Oct 1, 2024

PR Summary

The particle_leapfrog example was generating a compiler error in #910. I was able to reproduce this error with NVHPC 24.7.0/nvcc 12.5 on a Darwin volta-x86 node. Turns out we can't capture a Kokkos::Array of Kokkos::Arrays as a reference inside device code. I changed this to a copy and the code compiles for me (up to an ICE in poisson_package.cpp I am unsure about)

@fglines-nv This should fix the build error you encountered.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@brryan brryan added the bug Something isn't working label Oct 1, 2024
@brryan brryan requested review from Yurlungur and pgrete October 1, 2024 21:17
Copy link
Collaborator

@fglines-nv fglines-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just made this same change locally. This error doesn't appear with Cuda 12.2 but does appear with Cuda 12.5. Something must have changed between then

@Yurlungur Yurlungur enabled auto-merge October 2, 2024 15:57
@Yurlungur Yurlungur merged commit ea0d9b7 into develop Oct 2, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants