Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: The log rotation policy requires a file size limit #797

Open
sp0cket opened this issue May 14, 2024 · 2 comments
Open

Feat: The log rotation policy requires a file size limit #797

sp0cket opened this issue May 14, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@sp0cket
Copy link

sp0cket commented May 14, 2024

There may be situations where the size of logs cannot be predicted. For example, if a bug causes an abnormal amount of logs to be generated, it could fill up the disk and crash the system. A protection mechanism is needed to limit the maximum file size and delete old logs when the file becomes too large.

@nitisht
Copy link
Member

nitisht commented May 16, 2024

Thanks @sp0cket . We can mitigate this by allowing the log retention to work on files sizes also instead of days only. Will that work for you?

@nitisht nitisht added the enhancement New feature or request label May 16, 2024
@sp0cket
Copy link
Author

sp0cket commented May 16, 2024

I think both limits may be needed, and both may need to be cleaned up when either limit is reached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants