-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Routes for Modules #528
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pass in body and parseable to module
@aldrinjenson can you check the Deepsource / Rust issue here |
aldrinjenson
commented
Oct 10, 2023
trueleo
suggested changes
Oct 10, 2023
Co-authored-by: Satyam Singh <[email protected]> Signed-off-by: Nitish Tiwari <[email protected]>
nitisht
reviewed
Oct 12, 2023
aldrinjenson
force-pushed
the
panorama_config
branch
from
October 12, 2023 12:08
768636f
to
88f8dfb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #512
Description
Adds APIs for connecting Parseable with extendable modules
Final Routes:
GET /api/v1/modules/ : get list of all module names
PUT /api/v1/modules/{module} : update registration for given module
DEL /api/v1/modules/{module} : delete registration for given module
PUT /api/v1/{module}/config/{logstream} : Update config for a given module and proxy to module config path
GET /api/v1/{module}/config/{logstream} : Get config object for a given stream. (Called by module)
ALL /api/v1/{module}/* : directly proxied to module by parseable
This PR has: