Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring parseable instance with a toml file #1157

Open
de-sh opened this issue Feb 3, 2025 · 3 comments
Open

Allow configuring parseable instance with a toml file #1157

de-sh opened this issue Feb 3, 2025 · 3 comments
Labels
enhancement New feature or request server

Comments

@de-sh
Copy link
Contributor

de-sh commented Feb 3, 2025

Currently, parseable configs are extracted from env variables, this could become simpler if configs can be extracted from a TOML file.

@de-sh de-sh added enhancement New feature or request server labels Feb 3, 2025
@de-sh
Copy link
Contributor Author

de-sh commented Feb 3, 2025

We can use something like https://docs.rs/config/latest/config/trait.FileSource.html

@007harshmahajan
Copy link

so techincaly .toml is better for doing the config loading, some main pros

  • multiple config, like config.prod.toml or config.staging.toml
  • env is just string file, but toml can supports, boolen, arr etc
  • Its can be conrtolled where to be loaded and where not to be

@de-sh
Copy link
Contributor Author

de-sh commented Feb 9, 2025

so techincaly .toml is better for doing the config loading, some main pros

  • multiple config, like config.prod.toml or config.staging.toml
  • env is just string file, but toml can supports, boolen, arr etc
  • Its can be conrtolled where to be loaded and where not to be

Yes Harsh, that is why the issue was raised. Would be really helpful for users to have an easy to configure setup where we need not have to keep passing env variables and wonder why they break sometimes, such as in the case of inaccessible environments like that in the case of systemd services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request server
Projects
None yet
Development

No branches or pull requests

2 participants