Skip to content

Docker image doesn't conform to best practices #8360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
Tracked by #8225
cbaker6 opened this issue Dec 23, 2022 · 5 comments · Fixed by #8359
Closed
3 tasks done
Tracked by #8225

Docker image doesn't conform to best practices #8360

cbaker6 opened this issue Dec 23, 2022 · 5 comments · Fixed by #8359
Labels
state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:feature New feature or improvement of existing feature

Comments

@cbaker6
Copy link
Contributor

cbaker6 commented Dec 23, 2022 •
edited
Loading

New Feature / Enhancement Checklist

Current Limitation

The Dockerfile currently doesn't conform to the docker best practices or alpine recommendations. This results in a larger than necessary compressed/decompressed image.

Feature / Enhancement Description

The current compressed parse-server image size(~93MB) can be as close as possible to the lts-alpine image size (~50MB) by following best practices for constructing a Dockerfile. I've built a docker image of parse-server:6.0.0-alpha.17 with the changes in this PR and it resulted in a 68MB compressed image compared to the parse-community version of 93MB; 27% smaller.

Example Use Case

Create an image from this image.

Alternatives / Workarounds

Use bloated image as is.

3rd Party References

Noted in limitation links.
@parse-github-assistant
Copy link

parse-github-assistant bot commented Dec 23, 2022 •
edited
Loading

Thanks for opening this issue!

  • 🎉 We are excited about your ideas for improvement!

@cbaker6 cbaker6 mentioned this issue Dec 23, 2022
Merged
4 tasks
@mtrezza mtrezza added type:feature New feature or improvement of existing feature state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message labels Dec 23, 2022
@mtrezza
Copy link
Member

mtrezza commented Jan 9, 2023

Looks like a fit for the Parse Server 6 release. Added to the tracking list.

@mtrezza mtrezza mentioned this issue Jan 9, 2023
Closed
31 tasks
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0-alpha.24

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jan 9, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jan 31, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:feature New feature or improvement of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Reduce Docker image size by improving stages
3 participants
@mtrezza @cbaker6 @parseplatformorg