Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest changes to setup broke non OSX setup #1945

Closed
palladionIT opened this issue Jan 27, 2025 · 1 comment · Fixed by #1961
Closed

Latest changes to setup broke non OSX setup #1945

palladionIT opened this issue Jan 27, 2025 · 1 comment · Fixed by #1961
Assignees
Labels
bug Something isn't working

Comments

@palladionIT
Copy link

Issue Description

It seems that recent changes broke the setup function for zombinet. I followed the guide from the polkadot.com documentation that advises on using zombienet to spinup a local test instance using docker. However, the step where where I am supposed to call npm run zombie -- setup polkadot polkadot-parachain fails because recent changes to setup.ts seem to have broken release selection for non OSX targets.

After some debugging, it seems that this line breaks the release selection in the latestPolkadotReleaseURL function. Especially line 283 looks for exact equality when selecting the URL. However, with the recent changes what gets passed as name is polkadot- with a trailing dash and then this check fails and no release can be selected.

I hope that makes sense, in case it does not, I am happy to provide more info on the issue.

Steps to reproduce the issue

Steps to reproduce the issue

  1. Download the latest zombienet docker image
  2. Try to run npm run zombie -- setup polkadot inside the image

Describe the results you received

A very undescriptive error message of undefined shows up.

Describe the results you expected

The correct binaries are being downloaded.

Zombienet version

1.3.119

Provider

Native

Provider version

## For binaries
polkadot 0.9.40-a2b62fb872b
polkadot-parachain 0.9.380-fe24f39507f

Upstream Latest Release

Yes

Additional environment details

Apple M4 docker host with latest linux docker images.

Additional information

No response

Screenshots

No response

@pepoviola pepoviola self-assigned this Feb 17, 2025
@pepoviola pepoviola added the bug Something isn't working label Feb 17, 2025
@pepoviola
Copy link
Collaborator

Hi @palladionIT thanks for report and sorry about the delay, I will fix it and draft a new release.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants