Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute contract benchmarks on CI #198

Open
xermicus opened this issue Feb 6, 2025 · 3 comments
Open

Execute contract benchmarks on CI #198

xermicus opened this issue Feb 6, 2025 · 3 comments
Labels

Comments

@xermicus
Copy link
Member

xermicus commented Feb 6, 2025

We need a CI workflow which executes the benchmarks (make bench) on our reference bench-marking hardware.

Additionally, the output from the code_size integration test should also be considered since this is an important metric.

I'd like to have this workflow executed after all other jobs finished and post the benchmark results (diffed against master) as a PR comment.

A follow up issue will be to create more benchmarks that focus on more realistic examples.

@xermicus xermicus added the CI label Feb 6, 2025
@athei
Copy link
Member

athei commented Feb 6, 2025

A follow up issue will be to create more benchmarks that focus on more realistic examples.

I think the plan is that those realistic benchmarks will live in https://github.com/paritytech/evm-test-suite. There is nothing stopping us from also using those tests as benchmarks.

@xermicus
Copy link
Member Author

xermicus commented Feb 6, 2025

Ah yes thanks for clarifying it, that was the idea. See also #199 - the same benchmark cases can just be used for both, regression testing on compilation and contract runtime performance.

@athei
Copy link
Member

athei commented Feb 6, 2025

Yeah I guess we can also measure the compilation time there. The tests are already there. We just need to start measuring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants