Merge pull request #1128 from parea-ai/fix-instructor-key-error

try catch report_instructor_validation_errors

Author: jalexanderII

.github/workflows/build.yml

@@ -7,27 +7,33 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: [ "3.8" ]
+        python-version: [ "3.11" ]
 
     steps:
-      - uses: actions/checkout@v4.1.1
+      - uses: actions/checkout@v4.2.2
       - name: Set up Python ${{ matrix.python-version }}
-        uses: actions/setup-python@v5.0.0
+        uses: actions/setup-python@v5
         with:
           python-version: ${{ matrix.python-version }}
 
-      - name: Install poetry
-        run: make poetry-download
-
-      - name: Set up cache
-        uses: actions/[email protected]
+      - name: Install Poetry
+        uses: snok/install-poetry@v1
+        with:
+          virtualenvs-create: true
+          virtualenvs-in-project: true
+          virtualenvs-path: .venv
+          installer-parallel: true
+
+      - name: Load cached venv
+        id: cached-poetry-dependencies
+        uses: actions/cache@v4
         with:
           path: .venv
-          key: venv-${{ matrix.python-version }}-${{ hashFiles('pyproject.toml') }}-${{ hashFiles('poetry.lock') }}
+          key: venv-${{ matrix.python-version }}-${{ hashFiles('poetry.lock') }}
+
       - name: Install dependencies
-        run: |
-          poetry config virtualenvs.in-project true
-          poetry install
+        if: steps.cached-poetry-dependencies.outputs.cache-hit != 'true'
+        run: poetry install --no-interaction --no-root
 
       - name: Run style checks
         run: |
@@ -36,7 +42,3 @@ jobs:
       - name: Run tests
         run: |
           make test
-
-#    - name: Run safety checks
-#      run: |
-#        make check-safety

.github/workflows/greetings.yml

@@ -6,7 +6,7 @@ jobs:
   greeting:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/first-interaction@v1
+    - uses: actions/first-interaction@v1.3.0
       with:
         repo-token: ${{ secrets.GITHUB_TOKEN }}
         pr-message:  'Hello @${{ github.actor }}, thank you for submitting a PR! We will respond as soon as possible.'

.github/workflows/release-drafter.yml

@@ -11,6 +11,6 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       # Drafts your next Release notes as Pull Requests are merged into "master"
-      - uses: release-drafter/release-drafter@v5.25.0
+      - uses: release-drafter/release-drafter@v6.0.0
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Makefile

@@ -41,7 +41,6 @@ formatting: codestyle
 .PHONY: test
 test:
 	PYTHONPATH=$(PYTHONPATH) poetry run pytest -c pyproject.toml --cov-report=html --cov=parea tests/
-	poetry run coverage-badge -o assets/images/coverage.svg -f
 
 .PHONY: check-codestyle
 check-codestyle:

parea/utils/trace_integrations/instructor.py

@@ -55,10 +55,12 @@ def report_instructor_validation_errors() -> None:
         reason=reason,
     )
     trace_update_dict = {"scores": [instructor_score]}
-    if children := trace_data.get()[instructor_trace_id.get()].children:
-        last_child_trace_id = children[-1]
-        trace_update_dict["configuration"] = trace_data.get()[last_child_trace_id].configuration
-    trace_insert(trace_update_dict, instructor_trace_id.get())
+    i_trace_id = instructor_trace_id.get()
+    if i_trace_id:
+        if children := trace_data.get()[i_trace_id].children:
+            last_child_trace_id = children[-1]
+            trace_update_dict["configuration"] = trace_data.get()[last_child_trace_id].configuration
+        trace_insert(trace_update_dict, i_trace_id)
     instructor_trace_id.set("")
     instructor_val_err_count.set(0)
     instructor_val_errs.set([])
@@ -99,7 +101,11 @@ def fn_transform_generator_outputs(items: List) -> str:
             reasons = get_reasons(e)
             instructor_val_errs.set(instructor_val_errs.get() + reasons)
 
-            report_instructor_validation_errors()
+            try:
+                report_instructor_validation_errors()
+            except Exception as e:
+                logger.error(f"Failed to report instructor validation errors: {e}", exc_info=e)
+
             current_log = trace_data.get()[trace_id]
             logger_update_record(UpdateLog(trace_id=trace_id, field_name_to_value_map={"scores": current_log.scores}, root_trace_id=current_log.root_trace_id))
 
@@ -120,5 +126,8 @@ def __call__(
                 reasons = get_reasons(args[1])
                 instructor_val_errs.set(instructor_val_errs.get() + reasons)
             else:
-                report_instructor_validation_errors()
+                try:
+                    report_instructor_validation_errors()
+                except Exception as e:
+                    logger.error(f"Failed to report instructor validation errors: {e}", exc_info=e)
         return wrapped(*args, **kwargs)