From ea76e677a7b3874516b731e07d139ed17e8fb236 Mon Sep 17 00:00:00 2001 From: Manoj Vivek Date: Thu, 21 Nov 2024 15:04:15 +0530 Subject: [PATCH 1/4] Added provisions to allow debuginfo status checks --- ui/packages/shared/components/src/ParcaContext/index.tsx | 1 + .../ProfileIcicleGraph/IcicleGraphArrow/ContextMenu.tsx | 8 +++++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/ui/packages/shared/components/src/ParcaContext/index.tsx b/ui/packages/shared/components/src/ParcaContext/index.tsx index bf36b08be0a..f4673f1b448 100644 --- a/ui/packages/shared/components/src/ParcaContext/index.tsx +++ b/ui/packages/shared/components/src/ParcaContext/index.tsx @@ -69,6 +69,7 @@ interface Props { additionalFlamegraphColorProfiles?: Record; timezone?: string; preferencesModal?: boolean; + checkDebuginfoStatusHandler?: (buildId: string) => void; } export const defaultValue: Props = { diff --git a/ui/packages/shared/profile/src/ProfileIcicleGraph/IcicleGraphArrow/ContextMenu.tsx b/ui/packages/shared/profile/src/ProfileIcicleGraph/IcicleGraphArrow/ContextMenu.tsx index ecb4f12f9ff..a640c8a5f23 100644 --- a/ui/packages/shared/profile/src/ProfileIcicleGraph/IcicleGraphArrow/ContextMenu.tsx +++ b/ui/packages/shared/profile/src/ProfileIcicleGraph/IcicleGraphArrow/ContextMenu.tsx @@ -59,7 +59,7 @@ const ContextMenu = ({ hideBinary, }: ContextMenuProps): JSX.Element => { const {isDarkMode} = useParcaContext(); - const {enableSourcesView} = useParcaContext(); + const { enableSourcesView, checkDebuginfoStatusHandler } = useParcaContext(); const [isGraphTooltipDocked, setIsDocked] = useUserPreference( USER_PREFERENCES.GRAPH_METAINFO_DOCKED.key ); @@ -222,6 +222,12 @@ const ContextMenu = ({ ))} + {checkDebuginfoStatusHandler !== undefined ? checkDebuginfoStatusHandler(mappingBuildID)} disabled={!isMappingBuildIDAvailable}> +
+ +
Check debuginfo status
+
+ : null}
From 19b3266f49f5e91bccbfad2ce0f639b966a4f5ba Mon Sep 17 00:00:00 2001 From: "pre-commit-ci-lite[bot]" <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Date: Thu, 21 Nov 2024 09:36:02 +0000 Subject: [PATCH 2/4] [pre-commit.ci lite] apply automatic fixes --- .../IcicleGraphArrow/ContextMenu.tsx | 25 +++++++++++++------ 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/ui/packages/shared/profile/src/ProfileIcicleGraph/IcicleGraphArrow/ContextMenu.tsx b/ui/packages/shared/profile/src/ProfileIcicleGraph/IcicleGraphArrow/ContextMenu.tsx index a640c8a5f23..81ebd7a8018 100644 --- a/ui/packages/shared/profile/src/ProfileIcicleGraph/IcicleGraphArrow/ContextMenu.tsx +++ b/ui/packages/shared/profile/src/ProfileIcicleGraph/IcicleGraphArrow/ContextMenu.tsx @@ -59,7 +59,7 @@ const ContextMenu = ({ hideBinary, }: ContextMenuProps): JSX.Element => { const {isDarkMode} = useParcaContext(); - const { enableSourcesView, checkDebuginfoStatusHandler } = useParcaContext(); + const {enableSourcesView, checkDebuginfoStatusHandler} = useParcaContext(); const [isGraphTooltipDocked, setIsDocked] = useUserPreference( USER_PREFERENCES.GRAPH_METAINFO_DOCKED.key ); @@ -222,12 +222,23 @@ const ContextMenu = ({ ))}
- {checkDebuginfoStatusHandler !== undefined ? checkDebuginfoStatusHandler(mappingBuildID)} disabled={!isMappingBuildIDAvailable}> -
- -
Check debuginfo status
-
- : null} + {checkDebuginfoStatusHandler !== undefined ? ( + checkDebuginfoStatusHandler(mappingBuildID)} + disabled={!isMappingBuildIDAvailable} + > +
+ +
+ Check debuginfo status{' '} + + + +
+
+ + ) : null}
From c8b33445e47e52b74ad67e74abccb015237e80ae Mon Sep 17 00:00:00 2001 From: Manoj Vivek Date: Thu, 21 Nov 2024 15:11:48 +0530 Subject: [PATCH 3/4] Type fix --- .../src/ProfileIcicleGraph/IcicleGraphArrow/ContextMenu.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/packages/shared/profile/src/ProfileIcicleGraph/IcicleGraphArrow/ContextMenu.tsx b/ui/packages/shared/profile/src/ProfileIcicleGraph/IcicleGraphArrow/ContextMenu.tsx index a640c8a5f23..09c77b0cd40 100644 --- a/ui/packages/shared/profile/src/ProfileIcicleGraph/IcicleGraphArrow/ContextMenu.tsx +++ b/ui/packages/shared/profile/src/ProfileIcicleGraph/IcicleGraphArrow/ContextMenu.tsx @@ -222,7 +222,7 @@ const ContextMenu = ({ ))}
- {checkDebuginfoStatusHandler !== undefined ? checkDebuginfoStatusHandler(mappingBuildID)} disabled={!isMappingBuildIDAvailable}> + {checkDebuginfoStatusHandler !== undefined ? checkDebuginfoStatusHandler(mappingBuildID as string)} disabled={!isMappingBuildIDAvailable}>
Check debuginfo status
From 9b995a565c3e2fb24e4cd94a717ab00a78e5904b Mon Sep 17 00:00:00 2001 From: "pre-commit-ci-lite[bot]" <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Date: Thu, 21 Nov 2024 09:44:35 +0000 Subject: [PATCH 4/4] [pre-commit.ci lite] apply automatic fixes --- .../IcicleGraphArrow/ContextMenu.tsx | 56 +++++++++---------- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/ui/packages/shared/profile/src/ProfileIcicleGraph/IcicleGraphArrow/ContextMenu.tsx b/ui/packages/shared/profile/src/ProfileIcicleGraph/IcicleGraphArrow/ContextMenu.tsx index e1d147dbad3..4b911f0a08d 100644 --- a/ui/packages/shared/profile/src/ProfileIcicleGraph/IcicleGraphArrow/ContextMenu.tsx +++ b/ui/packages/shared/profile/src/ProfileIcicleGraph/IcicleGraphArrow/ContextMenu.tsx @@ -11,19 +11,19 @@ // See the License for the specific language governing permissions and // limitations under the License. -import { Icon } from '@iconify/react'; -import { Table } from 'apache-arrow'; -import { Item, Menu, Separator, Submenu } from 'react-contexify'; -import { Tooltip } from 'react-tooltip'; +import {Icon} from '@iconify/react'; +import {Table} from 'apache-arrow'; +import {Item, Menu, Separator, Submenu} from 'react-contexify'; +import {Tooltip} from 'react-tooltip'; -import { useParcaContext, useURLState } from '@parca/components'; -import { USER_PREFERENCES, useUserPreference } from '@parca/hooks'; -import { ProfileType } from '@parca/parser'; -import { getLastItem } from '@parca/utilities'; +import {useParcaContext, useURLState} from '@parca/components'; +import {USER_PREFERENCES, useUserPreference} from '@parca/hooks'; +import {ProfileType} from '@parca/parser'; +import {getLastItem} from '@parca/utilities'; -import { useGraphTooltip } from '../../GraphTooltipArrow/useGraphTooltip'; -import { useGraphTooltipMetaInfo } from '../../GraphTooltipArrow/useGraphTooltipMetaInfo'; -import { hexifyAddress, truncateString } from '../../utils'; +import {useGraphTooltip} from '../../GraphTooltipArrow/useGraphTooltip'; +import {useGraphTooltipMetaInfo} from '../../GraphTooltipArrow/useGraphTooltipMetaInfo'; +import {hexifyAddress, truncateString} from '../../utils'; interface ContextMenuProps { menuId: string; @@ -58,8 +58,8 @@ const ContextMenu = ({ unit, hideBinary, }: ContextMenuProps): JSX.Element => { - const { isDarkMode } = useParcaContext(); - const { enableSourcesView, checkDebuginfoStatusHandler } = useParcaContext(); + const {isDarkMode} = useParcaContext(); + const {enableSourcesView, checkDebuginfoStatusHandler} = useParcaContext(); const [isGraphTooltipDocked, setIsDocked] = useUserPreference( USER_PREFERENCES.GRAPH_METAINFO_DOCKED.key ); @@ -84,7 +84,7 @@ const ContextMenu = ({ mappingFile, mappingBuildID, inlined, - } = useGraphTooltipMetaInfo({ table, row }); + } = useGraphTooltipMetaInfo({table, row}); const [_, setSearchString] = useURLState('search_string'); const [dashboardItems, setDashboardItems] = useURLState('dashboard_items', { @@ -95,7 +95,7 @@ const ContextMenu = ({ return <>; } - const { name, cumulativeText, diffText, diff } = contextMenuData; + const {name, cumulativeText, diffText, diff} = contextMenuData; const isMappingBuildIDAvailable = mappingBuildID !== null && mappingBuildID !== ''; @@ -116,33 +116,33 @@ const ContextMenu = ({ row === 0 ? '' : name !== '' - ? name - : locationAddress !== 0n - ? hexifyAddress(locationAddress) - : ''; + ? name + : locationAddress !== 0n + ? hexifyAddress(locationAddress) + : ''; const buildIdText = !isMappingBuildIDAvailable ? '' : mappingBuildID; const inlinedText = inlined === null ? 'merged' : inlined ? 'yes' : 'no'; const valuesToCopy = [ - { id: 'Function name', value: functionName }, + {id: 'Function name', value: functionName}, { id: 'Function system name', value: functionSystemName === functionName ? '' : functionSystemName, }, // an empty string will be filtered out below - { id: 'Cumulative', value: cumulativeText ?? '' }, - { id: 'Diff', value: diff !== 0n ? diffText : '' }, + {id: 'Cumulative', value: cumulativeText ?? ''}, + {id: 'Diff', value: diff !== 0n ? diffText : ''}, { id: 'File', value: functionFilename === '' ? functionFilename : file, }, - { id: 'Address', value: locationAddress === 0n ? '' : hexifyAddress(locationAddress) }, - { id: 'Inlined', value: inlinedText }, - { id: 'Binary', value: mappingFile ?? '' }, - { id: 'Build Id', value: buildIdText }, + {id: 'Address', value: locationAddress === 0n ? '' : hexifyAddress(locationAddress)}, + {id: 'Inlined', value: inlinedText}, + {id: 'Binary', value: mappingFile ?? ''}, + {id: 'Build Id', value: buildIdText}, ]; - const nonEmptyValuesToCopy = valuesToCopy.filter(({ value }) => value !== ''); + const nonEmptyValuesToCopy = valuesToCopy.filter(({value}) => value !== ''); return ( @@ -207,7 +207,7 @@ const ContextMenu = ({ } >
- {nonEmptyValuesToCopy.map(({ id, value }: { id: string; value: string }) => ( + {nonEmptyValuesToCopy.map(({id, value}: {id: string; value: string}) => (