Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[proposal] split charts for agent and server #37

Open
vd-rd opened this issue Jan 4, 2023 · 3 comments
Open

[proposal] split charts for agent and server #37

vd-rd opened this issue Jan 4, 2023 · 3 comments

Comments

@vd-rd
Copy link
Contributor

vd-rd commented Jan 4, 2023

As the two components might be deployed in different environment/cluster configurations, imo it makes sense to have separate charts to avoid cluttering them with options.
It is just a suggestion, I can refactor them in a PR if it makes sense for others as well
@brancz
Copy link
Member

brancz commented Jan 4, 2023

I'd be happy with that. @rlex wdyt?

@vd-rd
Copy link
Contributor Author

vd-rd commented Jan 6, 2023

I've also bumped in some chart limitations regarding rbac perms (limited to watching nodes) that aren't templated at the moment, and I've noticed an ongoing effort for refactoring the storage part in #34, which can be further expanded to a deployment+PVC option.

@brancz
Copy link
Member

brancz commented Jan 6, 2023

All of that sounds good to me, probably best to do piece by piece, but I'd be happy to review the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brancz @vd-rd