Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for external postgres secrets #112

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SorsOps
Copy link

@SorsOps SorsOps commented Feb 13, 2025

What does this PR change?

Does the PR depend on any other PRs or Issues? If yes, please list them.

  • No

Checklist

I confirm, that I have...

@SorsOps
Copy link
Author

SorsOps commented Feb 13, 2025

@akshay196 could you take a look when you have time ?

@akshay196
Copy link
Member

@SorsOps It is necessary to pass in dsn to Kratos installation. See

dsn: {{ include "ztka.dsn" . | b64enc | quote }}

Now using an existing secret is failing

Error: execution error at (ztka/templates/secret-kratos.yaml:11:10): A valid .Values.deploy.postgresql.username entry required!

@SorsOps
Copy link
Author

SorsOps commented Feb 16, 2025

Hi @akshay196 would you advocate in this case that we define something to disable the auto creation the kratos secret in the case that a user wants to use an existing secret and then add documentation on how to overwrite it ?

kratos:
  secret:
    enabled: false
    nameOverride: "kratos" # Override this 

@SorsOps
Copy link
Author

SorsOps commented Feb 25, 2025

@akshay196 as an alternative to this, what about if we used the lookup function in helm to get the values from another existing secret, and use this for the kratos secret, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for existing K8s secret for database credentials
2 participants