Remove mbstring.func_overload compatibility layer
#58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `mbstring.func_overload` misfeature no longer exists in PHP 8.x which is now the minimally supported version. Thus we can directly use `strlen()` and `substr()` and avoid the indirection through the `Binary` class, improving performance.
`mbstring.func_overload` is no more, thus this can be a direct wrapper of `strlen()` and `substr()` respectively.
|
The |
That's why I did not remove it and just marked it as Deprecated. |
|
It's not deprecated, either. Too many things use it, and marking it as deprecated will cause downstream issues with e.g. Psalm. |
|
Okay. Are you requesting me to drop the Deprecation commit? Shall I make any other changes to this PR or are the first two commits good? |
|
@paragonie-security Friendly ping regarding my question above. I'm happy to make the necessary changes to the PR, but would need to know what changes I should make. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mbstring.func_overloadmisfeature no longer exists in PHP 8.x which is now the minimally supported version. Thus we can directly usestrlen()andsubstr()and avoid the indirection through theBinaryclass, improving performance.