Skip to content

Commit

Permalink
Make CI fail louder
Browse files Browse the repository at this point in the history
  • Loading branch information
paragonie-security committed May 8, 2024
1 parent 0c08125 commit 18710d3
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/Fetch.php
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,11 @@ public function getLatestBundle($checkEd25519Signature = null, $checkChronicle =

// If the SHA256 doesn't match, fail fast.
if ($validator::checkSha256Sum($bundle)) {
/** @var bool $valid */
$valid = true;
if ($checkEd25519Signature) {
$valid = $valid && $validator->checkEd25519Signature($bundle);
$valid = $validator->checkEd25519Signature($bundle);
if (!$valid) {
var_dump('invalid signature for' . $bundle->getFilePath());
$this->markBundleAsBad($bundleIndex, 'Ed25519 signature mismatch');
}
}
Expand All @@ -112,6 +112,7 @@ public function getLatestBundle($checkEd25519Signature = null, $checkChronicle =
if ($validChronicle) {
unset($this->unverified[$index]);
} else {
var_dump('invalid chronicle entry for' . $bundle->getFilePath());
$this->markBundleAsBad($bundleIndex, 'Chronicle');
}
}
Expand Down

0 comments on commit 18710d3

Please sign in to comment.