Skip to content

Commit a3fe910

Browse files
committedMar 25, 2025·
fix failing tests
1 parent 63f06af commit a3fe910

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed
 

‎papermerge/core/features/custom_fields/db/api.py

+5-1
Original file line numberDiff line numberDiff line change
@@ -203,9 +203,13 @@ def update_custom_field(
203203
if attrs.group_id:
204204
cfield.user_id = None
205205
cfield.group_id = attrs.group_id
206-
else:
206+
elif attrs.user_id:
207207
cfield.user_id = attrs.user_id
208208
cfield.group_id = None
209+
else:
210+
raise ValueError(
211+
"Either attrs.user_id or attrs.group_id should be non-empty value"
212+
)
209213

210214
session.commit()
211215
result = schema.CustomField.model_validate(cfield)

‎papermerge/core/features/custom_fields/tests/test_dbapi_custom_fields.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ def test_custom_field_update(db_session: Session, user: User):
4545
dbapi.update_custom_field(
4646
db_session,
4747
custom_field_id=cfield.id,
48-
attrs=schema.UpdateCustomField(name="new_cf1_name"),
48+
attrs=schema.UpdateCustomField(name="new_cf1_name", user_id=user.id),
4949
)
5050

5151
updated_cf1 = dbapi.get_custom_field(db_session, cfield.id)

0 commit comments

Comments
 (0)