-
-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade CI to build on macOS 12 #21413
Labels
Comments
This was referenced Sep 16, 2024
huonw
added a commit
that referenced
this issue
Sep 16, 2024
This unblocks doing 2.24 dev releases while we get ourselves sorted and upgrade OSes on CI. Our current 2.23 builds are issuing the following warning, which becomes an error for 2.24-versioned builds (like #21412): ``` 14:44:14.41 [WARN] DEPRECATED: using Pants on macOS 10.15 - 11 is scheduled to be removed in version 2.24.0.dev0. Future versions of Pants will only run on macOS 12 and newer, but this machine appears older (macOS-10.15.7-x86_64-i386-64bit). You can temporarily silence this warning with the `[GLOBAL].allow_deprecated_macos_before_12` option. If you have questions or concerns about this, please reach out to us at https://www.pantsbuild.org/community/getting-help. ``` The underlying deprecation is that Pants 2.24..0.dev0 and newer will no longer support running of Pants on macOS < 12, and that includes our own in-repo builds. However, it's strictly more permissive to build on macOS 10.15 or 11, so we're "allowed" to do that even though it's after the deprecation time. Upgrading the runners properly is covered by #21413. The x86-64 change is in #21417.
huonw
added a commit
that referenced
this issue
Sep 23, 2024
This removes our use of the self-hosted 10.15 x86-64 runner in favour of a GitHub-hosted macOS 12 runner, implicitly changing our macOS version support in the process. Note: these macOS 12 runners are disappearing in #21333, so I think 2.24 will have to be the last release supporting macOS 12 "properly", and hopefully we'll have finished that release series before GitHub gets rid of them. An alternative that doesn't limit us to GitHub's timelines would be upgrading OS on the self-hosted runner. I'm disinclined from the alternative. Landing this PR as-is theoretically allows us to turn off the self-hosted runner and save money. Half of #21413
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
In #21074 / #21326, we deprecated running on macOS 11 and earlier, in favour of macOS 12. We should upgrade our CI to match this:
Additional context
Related issues/PRs:
The text was updated successfully, but these errors were encountered: