-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify accent and punctuation correction #1439
Comments
@ggurdin Let me know if there's any open questions in this! |
@wcjord Does the initial list of choices from grammar_lite ever contain tokens for each choice? Right now they seem to be empty, so constructs can't be assigned without calling getSpanDetails |
Put this info in span data model / match |
Waiting on https://github.com/pangeachat/2-step-choreographer/issues/356 to finish this |
In Spanish correction for just accents and punctation works fine. Only one solution given. Testing on android. However, closing '?' on corrections for questions asked do not appear. |
How do I test this @ggurdin? |
@linhtphung You would type a message with a grammar error that's only an error with accents or punctuation (i.e., in Spanish "¿Como estas?" => "¿Cómo estás?", the only difference is accents). When you open this error during IGC, you should only see one choice in the activity. |
I saw one choice |
Discussed in #1438
Originally posted by wcjord January 14, 2025
If a "grammar" correction is just about adding accents or punctuation, then maybe we should skip the generation of distractors and correction activity, instead giving the user just the correction.
In this case, we'd also exclude this from learning analytics, and consider these "without assistance" uses of the words involved.
Skipping this step would be 1) faster and 2) less expensive.
Code for identifying correction of this type:
@linhtphung If you're fine with this from a learning perspective (and I think you are), we can convert to an issue and knock it out pretty quickly.
The text was updated successfully, but these errors were encountered: