Skip to content

Conversation

@Jatinprajapati7869
Copy link

@Jatinprajapati7869 Jatinprajapati7869 commented Nov 13, 2025

Description

This PR refactors pandas/tests/io/pytables/test_select.py to replace the deprecated
ensure_clean_store helper with the modern pytest tmp_path fixture.

Changes

  • Removed all uses of ensure_clean_store
  • Added tmp_path to each affected test
  • Constructed temporary HDF5 paths using tmp_path / "file_X.h5"
  • Preserved all existing test logic and assertions

Local Testing

  • pre-commit passes locally
  • pytest pandas/tests/io/pytables/test_select.py passes locally

CI Note (Unrelated Failing Test)

CI reports an unrelated failure:

pandas/tests/series/test_ufunc.py::test_np_fix - XPASS(strict)

This test is not modified by this PR and appears to be caused by an
upstream NumPy-dev behavior change (see PR #51082).

All tests related to this PR pass successfully.

Please advise if a rebase is needed once upstream fixes land.

@Jatinprajapati7869 Jatinprajapati7869 force-pushed the test-select-ensure_clean_store branch from 9342deb to 794ec8c Compare November 14, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TST: Replace ensure_clean utility function with the temp_file pytest fixture

1 participant