-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
BUG: .describe() doesn't work for EAs #61707 #61760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,7 @@ | |
) | ||
from typing import ( | ||
TYPE_CHECKING, | ||
Any, | ||
cast, | ||
) | ||
|
||
|
@@ -215,6 +216,14 @@ def reorder_columns(ldesc: Sequence[Series]) -> list[Hashable]: | |
return names | ||
|
||
|
||
def has_multiple_internal_dtypes(d: list[Any]) -> bool: | ||
"""Check if the sequence has multiple internal dtypes.""" | ||
if not d: | ||
return False | ||
|
||
return any(type(item) != type(d[0]) for item in d) | ||
|
||
|
||
def describe_numeric_1d(series: Series, percentiles: Sequence[float]) -> Series: | ||
"""Describe series containing numerical data. | ||
|
||
|
@@ -251,6 +260,10 @@ def describe_numeric_1d(series: Series, percentiles: Sequence[float]) -> Series: | |
import pyarrow as pa | ||
|
||
dtype = ArrowDtype(pa.float64()) | ||
elif has_multiple_internal_dtypes(d): | ||
# GH61707: describe() doesn't work on EAs | ||
# with multiple internal dtypes, so return object dtype | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is the relevant characteristic "multiple internal dtypes" or "entries that cant be cast to Float64"? |
||
dtype = None | ||
else: | ||
dtype = Float64Dtype() | ||
elif series.dtype.kind in "iufb": | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -95,6 +95,32 @@ def test_describe_empty_object(self): | |
assert np.isnan(result.iloc[2]) | ||
assert np.isnan(result.iloc[3]) | ||
|
||
def test_describe_multiple_dtypes(self): | ||
""" | ||
GH61707: describe() doesn't work on EAs which generate | ||
statistics with multiple dtypes. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nitpick can this be a comment instead of a docstring |
||
""" | ||
from decimal import Decimal | ||
|
||
from pandas.tests.extension.decimal import to_decimal | ||
|
||
s = Series(to_decimal([1, 2.5, 3]), dtype="decimal") | ||
|
||
expected = Series( | ||
[ | ||
3, | ||
Decimal("2.166666666666666666666666667"), | ||
Decimal("0.8498365855987974716713706849"), | ||
Decimal("1"), | ||
Decimal("3"), | ||
], | ||
index=["count", "mean", "std", "min", "max"], | ||
dtype="object", | ||
) | ||
|
||
result = s.describe(percentiles=[]) | ||
tm.assert_series_equal(result, expected) | ||
|
||
def test_describe_with_tz(self, tz_naive_fixture): | ||
# GH 21332 | ||
tz = tz_naive_fixture | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this can be inlined since it is only used once