Skip to content

DOC: remove regex argument from .str.rsplit docs #46488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MarcoGorelli opened this issue Mar 23, 2022 · 6 comments · Fixed by #46835
Closed

DOC: remove regex argument from .str.rsplit docs #46488

MarcoGorelli opened this issue Mar 23, 2022 · 6 comments · Fixed by #46835
Assignees
Labels
API - Consistency Internal Consistency of API/Behavior Enhancement Strings String extension data type and string data

Comments

@MarcoGorelli
Copy link
Member

MarcoGorelli commented Mar 23, 2022

Is your feature request related to a problem?

.str.split has a regex argument, which was added in #44185

Should .str.rsplit also take it?

EDIT

re.Pattern has split, but not rsplit, so this isn't straightforward without some crazy workaround. Let's just separate out the split and rsplit docs such that the rsplit ones don't have the regex argument

Currently, the argument is documented, but can't be passed https://pandas.pydata.org/docs/reference/api/pandas.Series.str.rsplit.html?highlight=rsplit#pandas.Series.str.rsplit

@MarcoGorelli MarcoGorelli added Enhancement Needs Triage Issue that has not been reviewed by a pandas team member labels Mar 23, 2022
@rhshadrach
Copy link
Member

+1 on the consistency here.

@mzeitlin11 mzeitlin11 added Strings String extension data type and string data API - Consistency Internal Consistency of API/Behavior and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Mar 25, 2022
@mzeitlin11 mzeitlin11 added this to the Contributions Welcome milestone Mar 25, 2022
@banditelol
Copy link

Hello, I'm interested in working on this issue, looking around I assume this entails:

  • Implementing similar logic from .str.split to .str.rsplit
  • Writing additional test code

And I also noticed that the documentation has already been applied, so there's no need to update it right?

@MarcoGorelli
Copy link
Member Author

@banditelol apologies, I'd suggested this issue to a co-worker who I think had started working on it, but they hadn't commented "take" - let's quickly check with them. @dykim29 are you still working on this?

@dykim29
Copy link
Contributor

dykim29 commented Mar 27, 2022

Hi @banditelol @MarcoGorelli I did start working on this! Still very new to this so didn’t comment ‘take’, apologies!

@dykim29
Copy link
Contributor

dykim29 commented Mar 27, 2022

take

@banditelol
Copy link

Okaay, good luck with the issue!
I'll look around again then

@MarcoGorelli MarcoGorelli changed the title ENH: let .str.rsplit take regex argument ENH: remove regex argument from .str.rsplit docs Apr 8, 2022
@MarcoGorelli MarcoGorelli changed the title ENH: remove regex argument from .str.rsplit docs DOC: remove regex argument from .str.rsplit docs Apr 8, 2022
@dykim29 dykim29 mentioned this issue Apr 22, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API - Consistency Internal Consistency of API/Behavior Enhancement Strings String extension data type and string data
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants