-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: remove regex
argument from .str.rsplit
docs
#46488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
+1 on the consistency here. |
Hello, I'm interested in working on this issue, looking around I assume this entails:
And I also noticed that the documentation has already been applied, so there's no need to update it right? |
@banditelol apologies, I'd suggested this issue to a co-worker who I think had started working on it, but they hadn't commented "take" - let's quickly check with them. @dykim29 are you still working on this? |
Hi @banditelol @MarcoGorelli I did start working on this! Still very new to this so didn’t comment ‘take’, apologies! |
take |
Okaay, good luck with the issue! |
.str.rsplit
take regex
argumentregex
argument from .str.rsplit
docs
regex
argument from .str.rsplit
docsregex
argument from .str.rsplit
docs
Is your feature request related to a problem?
.str.split
has aregex
argument, which was added in #44185Should
.str.rsplit
also take it?EDIT
re.Pattern
hassplit
, but notrsplit
, so this isn't straightforward without some crazy workaround. Let's just separate out thesplit
andrsplit
docs such that thersplit
ones don't have theregex
argumentCurrently, the argument is documented, but can't be passed https://pandas.pydata.org/docs/reference/api/pandas.Series.str.rsplit.html?highlight=rsplit#pandas.Series.str.rsplit
The text was updated successfully, but these errors were encountered: