Skip to content

[TST] Revise test_astype_str_map #28454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
makbigc opened this issue Sep 16, 2019 · 4 comments
Closed

[TST] Revise test_astype_str_map #28454

makbigc opened this issue Sep 16, 2019 · 4 comments
Assignees
@NumberPiOso
Labels
Clean Testing pandas testing functions or related to the test suite

Comments

@makbigc
Copy link
Contributor

makbigc commented Sep 16, 2019

follow up #28176 (review)

Right now, astype(str) converts np.nan into string.

In [3]: pd.Series(['foo', np.nan]).astype(str)
Out[3]: 
0    foo
1    nan
dtype: object

After merging #28176, astype(str) will preserve np.nan.

Review test_astype_str_map in pandas/tests/series/test_dtypes.py to get rid of any skipna keyword argument.
@jbrockmendel jbrockmendel added the Testing pandas testing functions or related to the test suite label Sep 18, 2019
@bhuvanakundumani
Copy link
Contributor

I am interested in working on this.

@mroeschke mroeschke added Refactor Internal refactoring of code Clean and removed Refactor Internal refactoring of code labels May 22, 2020
@NumberPiOso
Copy link
Contributor

take

@NumberPiOso NumberPiOso mentioned this issue Feb 1, 2022
Closed
@NumberPiOso
Copy link
Contributor

I am trying to define necessary actions to correct this. Please follow

#28176 (comment)

@mroeschke
Copy link
Member

Looks like there is no skipna kwargs in this test now so closing. Happy to reopen if misunderstood

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NumberPiOso NumberPiOso

Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bhuvanakundumani @jbrockmendel @mroeschke @makbigc @NumberPiOso