remove slice and tuple from groupby getitem

Author: Dr-Irv

pandas-stubs/core/groupby/generic.pyi

@@ -229,10 +229,8 @@ class DataFrameGroupBy(GroupBy[DataFrame], Generic[ByT]):
     def filter(
         self, func: Callable, dropna: bool = ..., *args, **kwargs
     ) -> DataFrame: ...
-    @overload  # type: ignore[override]
-    def __getitem__(self, key: slice) -> DataFrameGroupBy[ByT]: ...
     @overload
-    def __getitem__(self, key: Scalar | tuple[Hashable, ...]) -> SeriesGroupBy[Any, ByT]: ...  # type: ignore[overload-overlap] # pyright: ignore[reportOverlappingOverload]
+    def __getitem__(self, key: Scalar) -> SeriesGroupBy[Any, ByT]: ...  # type: ignore[overload-overlap] # pyright: ignore[reportOverlappingOverload]
     @overload
     def __getitem__(  # pyright: ignore[reportIncompatibleMethodOverride]
         self, key: Iterable[Hashable]

pandas-stubs/core/groupby/groupby.pyi

@@ -139,22 +139,15 @@ class BaseGroupBy(SelectionMixin[NDFrameT], GroupByIndexingMixin):
     @final
     def __iter__(self) -> Iterator[tuple[Hashable, NDFrameT]]: ...
     @overload
-    def __getitem__(self: BaseGroupBy[DataFrame], key: Scalar | tuple[Hashable, ...]) -> generic.SeriesGroupBy: ...  # type: ignore[overload-overlap] # pyright: ignore[reportOverlappingOverload]
+    def __getitem__(self: BaseGroupBy[DataFrame], key: Scalar) -> generic.SeriesGroupBy: ...  # type: ignore[overload-overlap] # pyright: ignore[reportOverlappingOverload]
     @overload
     def __getitem__(
-        self: BaseGroupBy[DataFrame], key: Iterable[Hashable] | slice
+        self: BaseGroupBy[DataFrame], key: Iterable[Hashable]
     ) -> generic.DataFrameGroupBy: ...
     @overload
     def __getitem__(
         self: BaseGroupBy[Series[S1]],
-        idx: (
-            list[str]
-            | Index
-            | Series[S1]
-            | slice
-            | MaskType
-            | tuple[Hashable | slice, ...]
-        ),
+        idx: list[str] | Index | Series[S1] | MaskType | tuple[Hashable | slice, ...],
     ) -> generic.SeriesGroupBy: ...
     @overload
     def __getitem__(self: BaseGroupBy[Series[S1]], idx: Scalar) -> S1: ...

tests/test_groupby.py

@@ -1052,3 +1052,9 @@ def test_engine() -> None:
             other_kwarg="",
         )
     GB_DF.aggregate("size", engine="cython", engine_kwargs={})
+
+
+def test_groupby_getitem() -> None:
+    df = DataFrame(np.random.random((3, 4)), columns=["a", "b", "c", "d"])
+    check(assert_type(df.groupby("a")["b"].sum(), Series), Series, float)
+    check(assert_type(df.groupby("a")[["b", "c"]].sum(), DataFrame), DataFrame)