Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unique filter does not work when chain with a filter that returns async generator #1781

Open
sileht opened this issue Dec 23, 2022 · 0 comments · May be fixed by #1782
Open

unique filter does not work when chain with a filter that returns async generator #1781

sileht opened this issue Dec 23, 2022 · 0 comments · May be fixed by #1782

Comments

@sileht
Copy link
Contributor

sileht commented Dec 23, 2022

unique() filter does not work when chain with a filter that returns async generator

Environment:

  • Python version: 3.11
  • Jinja version: 3.1.2

The template:

{%- set commit_authors = commits | rejectattr("author", "eq", "mergify[bot]") | unique(false, "email_author")| list -%}

The backtrace:

  File "xxxxxx.py", line 2314, in render_template
    return await env.from_string(template).render_async(**infos)
  File "jinja2/environment.py", line 1324, in render_async
    return self.environment.handle_exception()
  File "jinja2/environment.py", line 936, in handle_exception
    raise rewrite_traceback_stack(source=source)
  File "jinja2/environment.py", line 1321, in <listcomp>
    [n async for n in self.root_render_func(ctx)]  # type: ignore
  File "<template>", line 7, in top-level template code
  File "jinja2/async_utils.py", line 65, in auto_await
    return await t.cast("t.Awaitable[V]", value)
  File "jinja2/filters.py", line 1329, in do_list
    return await auto_to_list(value)
  File "jinja2/async_utils.py", line 84, in auto_to_list
    return [x async for x in auto_aiter(value)]
  File "jinja2/async_utils.py", line 84, in <listcomp>
    return [x async for x in auto_aiter(value)]
  File "jinja2/async_utils.py", line 77, in auto_aiter
    for item in t.cast("t.Iterable[V]", iterable):
  File "jinja2/filters.py", line 437, in do_unique
    for item in value:
TypeError: 'async_generator' object is not iterable
sileht added a commit to sileht/jinja that referenced this issue Dec 23, 2022
@sileht
fix(filter): unique with async generator
a076db8 
unique() filter doesn't work chained after a filter that return an async generator.

This introduces a async variant of the filter transform the async
generator into a list to be able to apply the unique filter.

Fixes pallets#1781
@sileht sileht linked a pull request Dec 23, 2022 that will close this issue
Open
6 tasks
sileht added a commit to sileht/jinja that referenced this issue Dec 23, 2022
@sileht
fix(filter): unique with async generator
934f628 
unique() filter doesn't work chained after a filter that return an async generator.

This introduces a async variant of the filter transform the async
generator into a list to be able to apply the unique filter.

Fixes pallets#1781
sileht added a commit to sileht/jinja that referenced this issue Dec 30, 2022
@sileht
fix(filter): unique with async generator
005064b 
unique() filter doesn't work chained after a filter that return an async generator.

This introduces a async variant of the filter transform the async
generator into a list to be able to apply the unique filter.

Fixes pallets#1781
@nikierpan nikierpan mentioned this issue Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(filter): unique with async generator sileht/jinja
1 participant
@sileht