Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Typing to Project #69

Open
aenglander opened this issue May 21, 2024 · 2 comments · May be fixed by #81
Open

Add Typing to Project #69

aenglander opened this issue May 21, 2024 · 2 comments · May be fixed by #81
Assignees
@aenglander

Comments

@aenglander
Copy link
Contributor

aenglander commented May 21, 2024 •
edited
Loading

The project should support proper typing like the rest of the Pallets projects

See other Pallets projects

  • Add Typing to classes and functions
  • Add typing environment with mypy and pyright tests to tox
  • Add a run in Gitlab actions
@aenglander aenglander self-assigned this May 21, 2024
@davidism
Copy link
Member

Start with mypy with strict=False. Once all those messages are addressed, again with strict=True. Then with pyright and pyright --verifytypes.

@Abdur-rahmaanJ Abdur-rahmaanJ linked a pull request Jun 3, 2024 that will close this issue
Open
@Abdur-rahmaanJ
Copy link
Member

  • mypy strict false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aenglander aenglander

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(wip): Add typing pallets-eco/flask-principal
3 participants
@aenglander @davidism @Abdur-rahmaanJ