-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch gift so it doesn't break things. #93
base: master
Are you sure you want to change the base?
Conversation
I will test this on my project. |
So when I work with this I get the following error:
Additionally, I am getting a bunch of "Warnings" regarding the version of specific node modules that are 'wanted' vs. installed like: I also get this syntax error, though it doesn't actually error out on this:
Debug Log: |
@aCyborg what do you get for (if the lines in the error above are any indication, you need to check the version recommendations Here's what's required:
|
ah got yah, I'll take a look at the readme. My versions are: |
@aCyborg just updated my comment above... I hadn't added them to the readme here, Just on the project repo. |
@froboy Node v7 "is not long-term support" so is that just the version that was out when this patch was created? I am experiencing a "gift" issue on a project and looking for a solution. With homebrew it's easy to install node v6 or v8, but not v7. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@froboy doesn't the script to patch it need to be added to the package.json
file?
"scripts": {
"prepare": "patch-package"
},
@labbydev yea, sorry. It's been a while since I touched this. With |
This should probably be refactored to use this approach fourkitchens/emulsify-gulp#74 |
I got this working using the 4 kitchens approach in the branch |
This should resolve #92, but may very well break other things...
This PR:
gulp-gh-pages
)Since we update npm, this also changes from a shrinkwrap-based lockfile to the new npm-native lock.
I make no guarantees about this not breaking other things and I don't have a project to test it on, but it should work.