Skip to content

Commit 9447bd7

Browse files
steff456ccordoba12
authored andcommitted
Fix test failures in 0.28.0 with Jedi 0.13 (#627)
1 parent 697ebb1 commit 9447bd7

File tree

3 files changed

+18
-0
lines changed

3 files changed

+18
-0
lines changed

test/plugins/test_completion.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# Copyright 2017 Palantir Technologies, Inc.
2+
from distutils.version import LooseVersion
23
import os
4+
import jedi
5+
import pytest
36

47
from pyls import uris, lsp
58
from pyls.workspace import Document
@@ -42,6 +45,8 @@ def test_rope_import_completion(config, workspace):
4245
assert items is None
4346

4447

48+
@pytest.mark.skipif(LooseVersion(jedi.__version__) < LooseVersion('0.14.0'),
49+
reason='This test fails with previous versions of jedi')
4550
def test_jedi_completion(config):
4651
# Over 'i' in os.path.isabs(...)
4752
com_position = {'line': 1, 'character': 15}

test/plugins/test_definitions.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,13 @@
11
# Copyright 2017 Palantir Technologies, Inc.
2+
from distutils.version import LooseVersion
3+
import jedi
4+
import pytest
5+
26
from pyls import uris
37
from pyls.plugins.definition import pyls_definitions
48
from pyls.workspace import Document
59

10+
611
DOC_URI = uris.from_fs_path(__file__)
712
DOC = """def a():
813
pass
@@ -33,6 +38,8 @@ def test_definitions(config):
3338
assert [{'uri': DOC_URI, 'range': def_range}] == pyls_definitions(config, doc, cursor_pos)
3439

3540

41+
@pytest.mark.skipif(LooseVersion(jedi.__version__) < LooseVersion('0.14.0'),
42+
reason='This test fails with previous versions of jedi')
3643
def test_builtin_definition(config):
3744
# Over 'i' in dict
3845
cursor_pos = {'line': 8, 'character': 24}

test/plugins/test_symbols.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
11
# Copyright 2017 Palantir Technologies, Inc.
2+
from distutils.version import LooseVersion
3+
import jedi
4+
import pytest
5+
26
from pyls import uris
37
from pyls.plugins.symbols import pyls_document_symbols
48
from pyls.lsp import SymbolKind
@@ -21,6 +25,8 @@ def main(x):
2125
"""
2226

2327

28+
@pytest.mark.skipif(LooseVersion(jedi.__version__) < LooseVersion('0.14.0'),
29+
reason='This test fails with previous versions of jedi')
2430
def test_symbols(config):
2531
doc = Document(DOC_URI, DOC)
2632
config.update({'plugins': {'jedi_symbols': {'all_scopes': False}}})

0 commit comments

Comments
 (0)