Some addPermittedSubclass methods call invalid addSuperinterface inside.

[skku-daniilkim]

What happened?

TypeSpec.addPermittedSubclass(Type permittedSubclass) and TypeSpec.addPermittedSubclass(TypeMirro permittedSubclass) incorrectly call TypeSpec.addSuperinterface(... superinterface, boolean avoidNestedTypeNameClashes) instead of TypeSpec.addPermittedSubclass(... superinterface, boolean avoidNestedTypeNameClashes):

javapoet/javapoet/src/main/java/com/palantir/javapoet/TypeSpec.java

Lines 756 to 758 in 9fb628c

	public Builder addPermittedSubclass(Type permittedSubclass) {
	return addSuperinterface(permittedSubclass, true);
	}

javapoet/javapoet/src/main/java/com/palantir/javapoet/TypeSpec.java

Lines 771 to 773 in 9fb628c

	public Builder addPermittedSubclass(TypeMirror permittedSubclass) {
	return addSuperinterface(permittedSubclass, true);
	}

What did you want to happen?

They should call the TypeSpec.addPermittedSubclass(... superinterface, boolean avoidNestedTypeNameClashes).

[carterkozak]

That looks like a bug! Would you like to PR a fix? (I think you’ve opened a pr, but into your own fork)

[skku-daniilkim]

Oh yeah, my bad. Fixed the PR.