Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeBlock now checks if too many arguments are provided (#65). #76

Merged
merged 4 commits into from
Sep 19, 2024
Merged

CodeBlock now checks if too many arguments are provided (#65). #76

merged 4 commits into from
Sep 19, 2024

Conversation

skku-daniilkim
Copy link
Contributor

Before this PR

CodeBlock#of does not properly check if too many arguments are provided if there is no format specifier (#65).

After this PR

Fixes #65.

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented Sep 19, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

CodeBlock now checks if too many arguments are provided (#65).

Check the box to generate changelog(s)

  • Generate changelog entry

@skku-daniilkim
Copy link
Contributor Author

Sorry for multiple commits. If needed, I can squash all of them (although, I believe Github will do it by itself).

carterkozak
carterkozak approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@carterkozak carterkozak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@bulldozer-bot bulldozer-bot bot merged commit 04b6134 into palantir:develop Sep 19, 2024
4 of 5 checks passed
@autorelease3
Copy link

autorelease3 bot commented Sep 19, 2024

Released 0.5.0

@carterkozak
Copy link
Contributor

Sorry for multiple commits. If needed, I can squash all of them (although, I believe Github will do it by itself).

Not a problem, the robots take care of squashing commits together when our PRs are merged :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carterkozak carterkozak carterkozak approved these changes

Assignees
No one assigned
Labels
autorelease merge when ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CodeBlock.Builder#add does not detect unused args when no placeholder exists
2 participants
@skku-daniilkim @carterkozak