Remove uses of unsafe.
#142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jswrenn
force-pushed
the
look-ma-no-unsafe
branch
2 times, most recently
from
b83370b to
a2c1ea1
Compare
jswrenn
force-pushed
the
look-ma-no-unsafe
branch
from
a2c1ea1 to
9ce20ce
Compare
jswrenn
commented
Mar 22, 2020
src/uint.rs
Outdated
Comment on lines
1225
to
1226
| where | ||
| Bn: Copy |
There was a problem hiding this comment.
The Bn: Copy bound is needed so we can produce an instance of the least significant bit from a reference to a UInt.
There was a problem hiding this comment.
I have no objection to this, but couldn't we alternatively make get_bit take things by value?
There was a problem hiding this comment.
We could! We'd just need to add an extra Copy bound to the PartialDiv* implementations.
Per #63 (comment), this may not actually pose any performance issue. |
paholg
reviewed
Apr 1, 2020
src/uint.rs
Outdated
Comment on lines
1225
to
1226
| where | ||
| Bn: Copy |
There was a problem hiding this comment.
I have no objection to this, but couldn't we alternatively make get_bit take things by value?
paholg
reviewed
Apr 4, 2020
|
Thanks again for doing this, I am very excited to get it merged. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126 by completely removing all instances of
unsafe. Instead,Unsignedvalues are flowed through the methodscore::opsandtype_operatortraits. The appropriate methods have been added to thePrivate*traits, as needed.This pull request takes an aggressive approach, but it may not be desirable to remove all instances of
unsafe. This pull request:TArrI'll spotlight where these changes occur with pull-request comments.