Skip to content

Commit 900bd39

Browse files
committed
Rename run_httpd.sh and occurences
We no longer run httpd.
1 parent 1b624db commit 900bd39

File tree

8 files changed

+14
-14
lines changed

8 files changed

+14
-14
lines changed

CONTRIBUTING.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,11 @@ This repository contains [docker-compose.yml](./docker-compose.yml) for
4747
(can be also [used with podman](https://fedoramagazine.org/use-docker-compose-with-podman-to-orchestrate-containers-on-fedora)).
4848
Before you run it, we suggest that you open the file and read all the comments.
4949
You can also run only certain pieces of packit-service for local development
50-
(e.g. worker, database or service/httpd).
50+
(e.g. worker, database or http service).
5151
You also need to populate `secrets/packit/dev/` manually, for instructions
5252
see [deployment repo](https://github.com/packit/deployment/tree/main/secrets).
5353

54-
When you are running service/httpd and making requests to it,
54+
When you are running http service and making requests to it,
5555
make sure that `server_name` configuration file in `packit-service.yaml` is set.
5656

5757
### tokman
@@ -84,7 +84,7 @@ For this reason `docker-compose` needs access to ports lower than 1024:
8484
### binding on other hosts
8585

8686
If you are not binding the service on `localhost`
87-
then you **need** to make requests to httpd using the hostname
87+
then you **need** to make requests to http service using the hostname
8888
(which can be done by creating a new entry in `/etc/hosts` on your laptop)
8989
and you have to provide a route to that host.
9090

docker-compose.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ services:
130130
args:
131131
SOURCE_BRANCH: main
132132
image: quay.io/packit/packit-service:dev
133-
command: /usr/bin/run_httpd.sh
133+
command: /usr/bin/run_server.sh
134134
depends_on:
135135
- redis
136136
- postgres
@@ -157,7 +157,7 @@ services:
157157
- ./secrets/packit/dev/fedora.keytab:/secrets/fedora.keytab:ro,z
158158
- ./secrets/packit/dev/fullchain.pem:/secrets/fullchain.pem:ro,z
159159
- ./secrets/packit/dev/privkey.pem:/secrets/privkey.pem:ro,z
160-
- ./files/run_httpd.sh:/usr/bin/run_httpd.sh:ro,z
160+
- ./files/run_server.sh:/usr/bin/run_server.sh:ro,z
161161
user: "1024"
162162

163163
dashboard:
@@ -172,7 +172,7 @@ services:
172172
# server_name: service.localhost
173173
# dashboard_url: https://dashboard.localhost:8443
174174
image: quay.io/packit/dashboard:stg
175-
command: /usr/bin/run_httpd.sh
175+
command: /usr/bin/run_server.sh
176176
depends_on:
177177
- service
178178
ports:

docs/database/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ the project which handles migrations and schema versioning for SQLAlchemy.
1010
To generate a migration script for your recent change you can use docker or
1111
more easily, with rootless podman, you can use our make target.
1212

13-
Both expect that the `alembic upgrade head` is run in [run_httpd.sh](../../files/run_httpd.sh)
13+
Both expect that the `alembic upgrade head` is run in [run_server.sh](../../files/run_server.sh)
1414
during (packit-)service pod/container start.
1515

1616
When modifying the migration manually, do not forget to update the downgrade

files/docker/Dockerfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Image for the web service (httpd), for celery worker see files/docker/Dockerfile.worker
1+
# Image for the web service, for celery worker see files/docker/Dockerfile.worker
22

33
FROM quay.io/packit/base:fedora
44

@@ -34,4 +34,4 @@ COPY alembic/ ./alembic/
3434

3535
EXPOSE 8443
3636

37-
CMD ["/usr/bin/run_httpd.sh"]
37+
CMD ["/usr/bin/run_server.sh"]

files/recipe.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@
99
packit_service_path: /src
1010
tasks:
1111
- import_tasks: tasks/common.yaml
12-
- import_tasks: tasks/httpd.yaml
12+
- import_tasks: tasks/server.yaml
File renamed without changes.
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# Copyright Contributors to the Packit project.
22
# SPDX-License-Identifier: MIT
33

4-
- name: Copy run_httpd.sh
4+
- name: Copy run_server.sh
55
ansible.builtin.copy:
6-
src: run_httpd.sh
7-
dest: /usr/bin/run_httpd.sh
6+
src: run_server.sh
7+
dest: /usr/bin/run_server.sh
88
mode: 0775

packit_service/models.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ def is_multi_threaded() -> bool:
9595
# fails to rollback you have to restart the workers so that they pick another session.
9696
singleton_session = Session()
9797
logger.debug("Going to use a single SQLAlchemy session.")
98-
else: # service/httpd
98+
else: # http service
9999
Session = scoped_session(Session)
100100
singleton_session = None
101101

0 commit comments

Comments
 (0)