Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitProject.get_pr_files_diff inconsistencies #895

Open
2 tasks
mfocko opened this issue Mar 7, 2025 · 0 comments
Open
2 tasks

GitProject.get_pr_files_diff inconsistencies #895

mfocko opened this issue Mar 7, 2025 · 0 comments
Labels
area/forgejo area/github Related to GitHub implementation. area/gitlab Related to GitLab implementation. complexity/single-task Regular task, should be done within days. kind/bug Something isn't working. workaround-exists There is an existing workaround that can be used in the meantime of implementing the issue.

Comments

@mfocko
Copy link
Member

mfocko commented Mar 7, 2025

What happened? What is the problem?

  1. Method is tied directly to a PR, should be a method on the PullRequest instead of a method on the GitProject that's relayed to a static method on the PullRequest.
  2. Not implemented for GitHub and GitLab.
  3. There's no documentation provided for the output of this method, it's just a dict… Ideally define a dataclass and enums for some reasonable interface that could be shared with implementation for other forges too.

What did you expect to happen?

n/a

Example URL(s)

n/a

Steps to reproduce

Workaround

  • There is an existing workaround that can be used until this issue is fixed.

Participation

  • I am willing to submit a pull request for this issue. (Packit team is happy to help!)
@mfocko mfocko added the kind/bug Something isn't working. label Mar 7, 2025
@lbarcziova lbarcziova moved this from new to priority-backlog in Packit Kanban Board Mar 10, 2025
@mfocko mfocko added area/github Related to GitHub implementation. area/gitlab Related to GitLab implementation. area/forgejo complexity/single-task Regular task, should be done within days. workaround-exists There is an existing workaround that can be used in the meantime of implementing the issue. labels Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/forgejo area/github Related to GitHub implementation. area/gitlab Related to GitLab implementation. complexity/single-task Regular task, should be done within days. kind/bug Something isn't working. workaround-exists There is an existing workaround that can be used in the meantime of implementing the issue.
Projects
Status: priority-backlog
Development

No branches or pull requests

1 participant