Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination of GitLab commit comments #894

Open
2 tasks
mfocko opened this issue Mar 7, 2025 · 0 comments
Open
2 tasks

Pagination of GitLab commit comments #894

mfocko opened this issue Mar 7, 2025 · 0 comments
Labels
area/gitlab Related to GitLab implementation. complexity/single-task Regular task, should be done within days. kind/bug Something isn't working.

Comments

@mfocko
Copy link
Member

mfocko commented Mar 7, 2025

What happened? What is the problem?

Output from the tests ran via make check-in-container:

tests/integration/gitlab/test_generic_commands.py::GenericCommands::test_get_commit_comments
  /src/ogr/services/gitlab/project.py:314: UserWarning: Calling a `list()` method without specifying `get_all=True` or `iterator=True` will return a maximum of 20 items. Your query returned 20 of 23 items. See https://python-gitlab.readthedocs.io/en/v4.4.0/api-usage.html#pagination for more details. If this was done intentionally, then this warning can be supressed by adding the argument `get_all=False` to the `list()` call. (python-gitlab: /usr/lib/python3.12/site-packages/gitlab/client.py:956)
    for comment in commit_object.comments.list()

What did you expect to happen?

Promises to return a list, should be returning a list.

Example URL(s)

No response

Steps to reproduce

Run `make check-in-container`

Workaround

  • There is an existing workaround that can be used until this issue is fixed.

Participation

  • I am willing to submit a pull request for this issue. (Packit team is happy to help!)
@mfocko mfocko added the kind/bug Something isn't working. label Mar 7, 2025
@lbarcziova lbarcziova moved this from new to backlog in Packit Kanban Board Mar 10, 2025
@mfocko mfocko added area/gitlab Related to GitLab implementation. complexity/single-task Regular task, should be done within days. labels Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gitlab Related to GitLab implementation. complexity/single-task Regular task, should be done within days. kind/bug Something isn't working.
Projects
Status: backlog
Development

No branches or pull requests

1 participant