Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xde: error on add_unicast should reflect underlying error #372

Open
rcgoodfellow opened this issue May 23, 2023 · 0 comments
Open

xde: error on add_unicast should reflect underlying error #372

rcgoodfellow opened this issue May 23, 2023 · 0 comments
Milestone

Comments

@rcgoodfellow
Copy link
Contributor

In this code we just set errno to EFAULT, which is confusing for debugging. The errno should be the underlying error code from e.

opte/xde/src/xde.rs

Lines 947 to 950 in f2614ac

let muh = mch.add_unicast(mac).map_err(|e| OpteError::System {
errno: EFAULT,
msg: format!("mac_unicast_add failed for {link_name}: {e}"),
})?;

@rcgoodfellow rcgoodfellow added this to the unscheduled milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant