From e781ba7fdab7ab894b8bedc5288a8320d1f934a6 Mon Sep 17 00:00:00 2001 From: iximeow Date: Fri, 18 Jul 2025 20:39:20 +0000 Subject: [PATCH] update `cc` crate most importantly this gets us https://github.com/rust-lang/cc-rs/pull/1496 which fixes https://github.com/oxidecomputer/helios/issues/192 -style miscompilation of neuxs (and several other binaries here). I suspect that for `clickhouse-admin-*`, `cockroach-admin`, and `dns-server` both errnos are present but the incorrect global `errno` goes unused - it's present through rustls/ring/aws-lc-rs/etc being compiled and linked in, but if TLS interfaces aren't used there (yet!) then it's not an issue (yet!). Nexus presents HTTPS though, so the `errno`-clobbery code is used there. Lets get that fixed. --- Cargo.lock | 4 ++-- workspace-hack/Cargo.toml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index cd95d9e25d..a783caf66f 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1200,9 +1200,9 @@ dependencies = [ [[package]] name = "cc" -version = "1.2.15" +version = "1.2.30" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "c736e259eea577f443d5c86c304f9f4ae0295c43f3ba05c21f1d66b5f06001af" +checksum = "deec109607ca693028562ed836a5f1c4b8bd77755c4e132fc5ce11b0b6211ae7" dependencies = [ "jobserver", "libc", diff --git a/workspace-hack/Cargo.toml b/workspace-hack/Cargo.toml index 0484c5d44a..fa00ce1119 100644 --- a/workspace-hack/Cargo.toml +++ b/workspace-hack/Cargo.toml @@ -166,7 +166,7 @@ bstr = { version = "1.10.0" } buf-list = { version = "1.0.3", default-features = false, features = ["tokio1"] } byteorder = { version = "1.5.0" } bytes = { version = "1.10.1", features = ["serde"] } -cc = { version = "1.2.15", default-features = false, features = ["parallel"] } +cc = { version = "1.2.30", default-features = false, features = ["parallel"] } chrono = { version = "0.4.41", features = ["serde"] } cipher = { version = "0.4.4", default-features = false, features = ["block-padding", "zeroize"] } clap = { version = "4.5.40", features = ["cargo", "derive", "env", "wrap_help"] }