Add option to print jkinds expanded for sake of Merlin #5041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldfirere
approved these changes
Nov 21, 2025
julesjacobs
reviewed
Nov 21, 2025
Contributor
julesjacobs
left a comment
julesjacobs
left a comment
There was a problem hiding this comment.
This looks good, but two things came to mind:
- Nothing seems to call the new functionality. Is this intended because only Merlin will call this from somewhere outside of this repo? (I don't know what the Merlin setup looks like)
- Is it possible to add an expect test for the new function? I guess that's hard with only end-to-end expect tests?
Contributor
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jkind api doesn't currently offer a way to print out a fully-expanded jkind. This PR adds such a function,
format_expanded, which will make it easy for Merlin to show the expanded jkind on hovers.It's impossible to write an expect-test in the compiler's testsuite that covers
format_expandedsince it's never used in the codebase. But I don't think this change needs high scrutiny, and this Merlin PR makes use of it.