refactor: remove unused expressions & async functions

Author: dev-737

src/commands/slash/Information/help.ts

@@ -74,6 +74,6 @@ export default class Help extends BaseCommand {
     For any questions, suggestions or feedback, join the [support server](${LINKS.SUPPORT_INVITE}) or [vote for InterChat](https://top.gg/bot/769921109209907241/vote).
     `);
 
-    paginate(interaction, [page1, page2, page3, page4]);
+    await paginate(interaction, [page1, page2, page3, page4]);
   }
 }

src/commands/slash/Main/hub/index.ts

@@ -359,6 +359,7 @@ export default class Hub extends BaseCommand {
     }
 
     const filtered = hubChoices?.map((hub) => ({ name: hub.name, value: hub.name }));
-    filtered ? await interaction.respond(filtered) : null;
+
+    if (filtered) await interaction.respond(filtered);
   }
 }

src/managers/BlacklistManager.ts

@@ -62,12 +62,12 @@ export default class BlacklistManager {
    * @param hubId The hub ID to remove the blacklist from.
    * @param expires The date or milliseconds to wait before removing the blacklist.
    */
-  async scheduleRemoval(
+  scheduleRemoval(
     type: 'server' | 'user',
     userOrServerId: string,
     hubId: string,
     expires: Date | number,
-  ): Promise<void> {
+  ): void {
     let name: string;
     let execute;
 

src/managers/CommandManager.ts

@@ -97,7 +97,7 @@ export default class CommandManager extends Factory {
           const subcommandFile = join(commandDir, '.', 'index.js');
           if (!statSync(subcommandFile).isFile()) return;
 
-          access(subcommandFile, constants.F_OK, async (err) => {
+          access(subcommandFile, constants.F_OK, (err) => {
             if (err || file === 'index.js') return;
 
             // get the parent command class from the subcommand

src/managers/NetworkManager.ts

@@ -133,11 +133,11 @@ export default class NetworkManager {
     // only assign to this variable if one of these two conditions are true, not always
     if (referredMessage) {
       if (referredMessage?.author.id === message.client.user.id) {
-        referredContent = await this.getReferredContent(referredMessage);
+        referredContent = this.getReferredContent(referredMessage);
         referredAuthor = message.client.user;
       }
       else if (referenceInDb) {
-        referredContent = await this.getReferredContent(referredMessage);
+        referredContent = this.getReferredContent(referredMessage);
         referredAuthor = await message.client.users.fetch(referenceInDb.authorId).catch(() => null);
       }
     }
@@ -429,7 +429,7 @@ export default class NetworkManager {
    * @param referredMessage The message being referred to.
    * @returns The content of the referred message.
    */
-  public async getReferredContent(referredMessage: Message) {
+  public getReferredContent(referredMessage: Message) {
     let referredContent = referredMessage.content || referredMessage.embeds[0]?.description;
 
     if (!referredContent) {
@@ -685,9 +685,9 @@ export default class NetworkManager {
           typeof message === 'string' ? { content: message, threadId } : { ...message, threadId };
 
         const webhook = new WebhookClient({ url: connection.webhookURL });
-        return webhook.send(payload).catch(() => null);
+        return await webhook.send(payload).catch(() => null);
       });
 
-    return res;
+    return await Promise.all(res);
   }
 }

src/services/HubLoggerService.ts

@@ -64,7 +64,7 @@ export default class HubLoggerService extends Factory {
    * @param embed The embed object containing the log message.
    */
   public async sendLog(channelId: string, embed: EmbedBuilder, content?: string) {
-    this.client.cluster.broadcastEval(
+    await this.client.cluster.broadcastEval(
       async (client, ctx) => {
         const channel = await client.channels.fetch(ctx.channelId).catch(() => null);
         if (!channel?.isTextBased()) return;