Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE] 12.4.0 #1438

Open
24 of 38 tasks
jesmrec opened this issue Jan 28, 2025 · 10 comments
Open
24 of 38 tasks

[RELEASE] 12.4.0 #1438

jesmrec opened this issue Jan 28, 2025 · 10 comments
Assignees
Labels
Approved by QA Approved by QA
Milestone

Comments

@jesmrec
Copy link
Contributor

jesmrec commented Jan 28, 2025

Release a new version

Xcode version to work with: Version 16.2 (16C5032a)

TASKS:

Git & Code

  • [GIT] Create branch release/[major].[minor].[patch] (freeze the code) release 12.4.0 #1440
  • [DEV] Update APP_SHORT_VERSION [major].[minor].[patch] in ownCloud.xcodeproj/project.pbxproj
  • [TRFX] Update translations from transifex branch.
  • [TRFX] Check for missing translations.
  • [DIS] Update changelog
  • [DEV] Update In-App Release Notes (changelog) in ownCloud/Release Notes/ReleaseNotes.plist
  • [DEV] Changelog: Created a folder for the new version like $majorVersion.$minorVersion.$patchVersion_YYYY-MM-DD
  • [DEV] Changelog: Moved all changelog files from the unreleased folder to the new version folder
  • [DEV] Inform Documentation-Team for the upcoming major/minor release with new version tag (notify #documentation-internal)
  • [QA] Design Test plan
  • [QA] Regression Test plan
  • [DOC] Update https://owncloud.com/mobile-apps/#ios version numbers (notify #marketing)
  • [GIT] Merge branch release/[major].[minor].[patch] in master
  • [GIT] Create tag and sign it [major].[minor].[patch]
  • [GIT] Add the new release on GitHub ios-app
  • [DEV] ownBrander: Update the ownBrander git tag in repository customer_portal to new release tag
  • [DEV] Update used Xcode version for the release in .xcode-version
  • [DEV] Inform #documentation about the new release to set new documentation branch tag

If it is required to update the iOS-SDK version:

  • [GIT] Create branch library release/[major].[minor].[patch](freeze the code)
  • [mail] inform #marketing about the new release.
  • [DIS] Update README.md (version number, third party, supported versions of iOS, Xcode)
  • [DIS] Update changelog
  • [GIT] Merge branch release/[major].[minor].[patch] in master
  • [GIT] Create tag and sign it [major].[minor].[patch]
  • [GIT] Add the new release on GitHub ios-sdk

If it is required to update third party:

  • [DIS] Update THIRD_PARTY.txt

App Store

  • [DIS] App Store Connect: Create a new version following the [major].[minor].[patch]
  • [DIS] App Store Connect: Trigger Fastlane screenshots generation and upload
  • [DIS] Upload the binary to the App Store
  • [DIS] App Store Connect: Trigger release (manually)
  • [DIS] App Store Connect: Decide reset of iOS summary rating (Default: keep)
  • [DIS] App Store Connect: Update description if necessary (coordinated with #marketing)
  • [DIS] App Store Connect: Update changelogs
  • [DIS] App Store Connect: Submit for review

BUGS & IMPROVEMENTS:

@DeepDiver1975 DeepDiver1975 mentioned this issue Jan 28, 2025
10 tasks
@jesmrec jesmrec added this to the 12.4-Next milestone Jan 28, 2025
@jesmrec
Copy link
Contributor Author

jesmrec commented Jan 29, 2025

(1) [WONT FIX]

That's bit weird..

  1. Open a txt file in order to preview it

Current:

Not previewed:

ScreenRecording_01-29-2025.09-20-50_1.MP4

Expected:

Previewed

I reproduce this in iPhone with iOS 18.2 with e0ab6fadf
With the same iPhone, it's not reproducible using the latest testflight version (build 293)
In iPadOS 17, works fine

Any idea, or extra info i can add?

Not a blocker, but a bit nasty.

@jesmrec
Copy link
Contributor Author

jesmrec commented Jan 29, 2025

(2) [FIXED]

  1. Add two accounts to the app
  2. In account 1, choose any file (no folder) and click on 3-dot-button
  3. Copy and then Copy to clipboard
  4. Go to account 2, and in top-right 3-dot-button menu, select Paste

Current:

Nothing happens:

ScreenRecording_01-29-2025.12-33-22_1.MP4

Expected:

File copied in step 2 is pasted in the account 2

With target in same account works fine

EDIT: Same bad behaviour with Cut option to Paste in another account

iPhoneXR 18.2
iPad2 17.4
e0ab6fadf67

@felix-schwarz
Copy link
Contributor

@jesmrec (1) What I see in that recording is that the file is downloaded, then passed to the iOS QLPreviewController for presentation. Why iOS chooses to show "1 copy 3, text, 754 bytes" instead of the text file I can't immediately tell. What's in that text file?

FWIW, I uploaded a simple text file with just "Test" in it - and it is shown:

Image


I'm looking at (2) right now.

@jesmrec
Copy link
Contributor Author

jesmrec commented Jan 30, 2025

@felix-schwarz this is the text file that i opened in the example video (there are several files with the same content):

1 copy 1.txt

i can provide the ad-hoc ipa i tested with

@felix-schwarz
Copy link
Contributor

felix-schwarz commented Jan 30, 2025

@jesmrec Re (1), testing on a real device with that file, I noticed that:
a) when it was downloaded the first time, it showed the placeholder as in your screenshot
b) closing the viewer and opening it again (with the file still downloaded), it then showed the file
c) erasing the local copy of the file, logging out, back in and then download the file a second time, it showed the file correctly (like in b)

Looking at the source code, nothing really sticks out that could cause this. If the file wasn't downloaded at the time it's handed to the QLPreviewController, the QLPreviewController couldn't show its correct file size.

Why QLPreviewController behaves that way for this file I can't really tell at this point. It doesn't look like we could do anything about it at the moment. At least, if it happens, it seems users can close the viewer and open it again to view the file.

Re (2): Should be fixed as of c72a986.

@jesmrec
Copy link
Contributor Author

jesmrec commented Jan 30, 2025

(3) [FIXED]

About conflict handling

  1. Open an image with the markup app in iOS.
  2. Open the same image in another client (i used the desktop client over a macbook)
  3. Modify the image in two different clients, saving the iOS app the lattest (to cause a conflict in the app)

Current:

App shows a technical http error 409

Image

Expected:

The iOS app does not show the conflict dialog (Keep Both - Replace - Cancel) that used to show.

Logs:

ownCloud_31_Jan_2025_at_08_58_02.log.txt

iPhone XR v18.2
iPad2 iPadOS 17.4
c72a986705

@felix-schwarz
Copy link
Contributor

FYI, I removed the "Send feedback" feature and bumped the build number in the latest commits.

@felix-schwarz
Copy link
Contributor

@jesmrec (3) should be fixed as of 99c2a20. Background: the server returns a 409 status code if the precondition in the If-Match header that references the edited version is not met. It previously expected a 412 (Precondition Failed) status to be returned in that case (which is also what OC10 does).

@jesmrec
Copy link
Contributor Author

jesmrec commented Jan 31, 2025

(3) fixed

@jesmrec
Copy link
Contributor Author

jesmrec commented Feb 3, 2025

Release 12.4.0 is OK from my side

Xcode version: 16.2 (16C5032a)

Approved commits:

  • app: 99c2a20d
  • sdk: 1bf0da8d

Regression test: https://github.com/owncloud/QA/blob/master/Mobile/iOS/Executions/Version%2012.4/Regression.md

E2E tests vs oCIS 7.0.0: https://reports.cucumber.io/reports/ceaa9efb-9924-49bd-8fdd-911a3974b4a1

Final notes:

  • Files provider issues got improved in this new version. Operations that include many files are still making the files provider to crash, probably for the swap memory limit.

Great work, team!! 🚀 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved by QA Approved by QA
Projects
None yet
Development

No branches or pull requests

4 participants