-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RELEASE] 12.4.0 #1438
Comments
(1) [WONT FIX]That's bit weird..
Current: Not previewed: ScreenRecording_01-29-2025.09-20-50_1.MP4Expected: Previewed I reproduce this in iPhone with iOS 18.2 with Any idea, or extra info i can add? Not a blocker, but a bit nasty. |
(2) [FIXED]
Current: Nothing happens: ScreenRecording_01-29-2025.12-33-22_1.MP4Expected: File copied in step 2 is pasted in the account 2 With target in same account works fine EDIT: Same bad behaviour with iPhoneXR 18.2 |
@jesmrec (1) What I see in that recording is that the file is downloaded, then passed to the iOS QLPreviewController for presentation. Why iOS chooses to show "1 copy 3, text, 754 bytes" instead of the text file I can't immediately tell. What's in that text file? FWIW, I uploaded a simple text file with just "Test" in it - and it is shown: I'm looking at (2) right now. |
@felix-schwarz this is the text file that i opened in the example video (there are several files with the same content): i can provide the ad-hoc ipa i tested with |
@jesmrec Re (1), testing on a real device with that file, I noticed that: Looking at the source code, nothing really sticks out that could cause this. If the file wasn't downloaded at the time it's handed to the Why Re (2): Should be fixed as of c72a986. |
(3) [FIXED]About conflict handling
Current: App shows a technical http error 409 Expected: The iOS app does not show the conflict dialog (Keep Both - Replace - Cancel) that used to show. Logs: ownCloud_31_Jan_2025_at_08_58_02.log.txt iPhone XR v18.2 |
FYI, I removed the "Send feedback" feature and bumped the build number in the latest commits. |
@jesmrec (3) should be fixed as of 99c2a20. Background: the server returns a 409 status code if the precondition in the |
(3) fixed |
Release Xcode version: Approved commits:
Regression test: https://github.com/owncloud/QA/blob/master/Mobile/iOS/Executions/Version%2012.4/Regression.md E2E tests vs oCIS 7.0.0: https://reports.cucumber.io/reports/ceaa9efb-9924-49bd-8fdd-911a3974b4a1 Final notes:
Great work, team!! 🚀 💯 |
Release a new version
Xcode version to work with: Version 16.2 (16C5032a)
TASKS:
Git & Code
release/[major].[minor].[patch]
(freeze the code) release 12.4.0 #1440APP_SHORT_VERSION
[major].[minor].[patch]
in ownCloud.xcodeproj/project.pbxprojrelease/[major].[minor].[patch]
in master[major].[minor].[patch]
customer_portal
to new release tagIf it is required to update the iOS-SDK version:
release/[major].[minor].[patch]
(freeze the code)release/[major].[minor].[patch]
inmaster
[major].[minor].[patch]
If it is required to update third party:
App Store
[major].[minor].[patch]
BUGS & IMPROVEMENTS:
The text was updated successfully, but these errors were encountered: