Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide trash bin icon for group "guest_app" #435

Open
hurradieweltgehtunter opened this issue Feb 25, 2021 · 1 comment
Open

Hide trash bin icon for group "guest_app" #435

hurradieweltgehtunter opened this issue Feb 25, 2021 · 1 comment

Comments

@hurradieweltgehtunter
Copy link
Contributor

hurradieweltgehtunter commented Feb 25, 2021

Steps to reproduce

  1. Go to user administration panel
  2. Click on "guest_app in the left sidebar
  3. Click on the trashbin icon to delete the group

Expected behaviour

As the "guest_app" group cannot be deleted it should not display the trashbin icon.

Actual behaviour

Trashbin icon shows, giving the user the idea that this group is deletable but it fails with a error message.
This is technically correct but bad and confusing user experience.

@cortho
Copy link
Contributor

cortho commented Feb 25, 2021

For implementation have a look at owncloud/core#28473 (comment) so virtual groups can be detected by
if ($groupObject->getBackend()->implementsActions(GroupInterface::DELETE_GROUP)) { ....

Edit: I think this is rather a core issue than a guests app specific one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants