Only call getGroupDetails if the group exists in the backend #40261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-davis
force-pushed
the
refactor-getGroupObject
branch
2 times, most recently
from
5b4e964 to
a7aa7de
Compare
jvillafanez
reviewed
Aug 3, 2022
phil-davis
force-pushed
the
refactor-getGroupObject
branch
from
a7aa7de to
6f73b1d
Compare
|
Kudos, SonarCloud Quality Gate passed! |
jvillafanez
approved these changes
Aug 3, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When getting a group, the getGroupDetails method could be called for a group that does not exist. That is unnecessary and may cause a group backend implementation to log an error. The code has been refactored to avoid this happening.
This was noticed while developing user_ldap changes related to group display names. See my comment: owncloud/user_ldap#748 (comment)
Related Issue
None
How Has This Been Tested?
CI - all existing group-related unit and acceptance tests are passing.
Types of changes
Checklist: