🔨 migrate images of unpublished gdoc posts that were missing #4281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The migration script used to filter for only images that are referenced in posts_gdocs_x_images. The idea was that this would keep only images that are used in any gdoc (regardless of publishing status), but it seems that there is a bug in updating the posts_gdocs_x_images table and it only happens for published posts.
This PR just gets rid of the check on posts_gdocs_x_images. This means that it will maybe transfer a few images to CF images that are actually unused but we can clean these up later (e.g. when we have the flat gdcos components table) and it seems more important to unblock authors today.
After this is merged and deployed the sync script has to be run again.