Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncated sources tab don't render short attribution #4180

Closed
sophiamersmann opened this issue Nov 18, 2024 · 0 comments · Fixed by #4186
Closed

Truncated sources tab don't render short attribution #4180

sophiamersmann opened this issue Nov 18, 2024 · 0 comments · Fixed by #4186

Comments

@sophiamersmann
Copy link
Member

Description

Tabs in the sources modal are truncated with '...' if they're too long. If they're truncated, then the short attribution is not rendered.

Expected behaviour

The short attribution should be rendered. The '...' should be rendered after the short attribution.

Steps to reproduce

  1. Go to https://ourworldindata.org/grapher/agri-environmental-policies-gdp
  2. Open the sources modal
  3. Note that one of the tabs has a lot of white space

Screenshots

Image

Technical explanation

overflow: ellipsis is applied the the button element but apparently can't deal with nested spans

Additional context

We want to move away from truncation and render multi-line labels instead, see #3654. If we do that, then fixing this is obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant