🐛 (admin) only evaluate chart series names once Grapher is ready

sophiamersmann · sophiamersmann · commit dc9a69ab2040 · 2024-12-17T16:23:40.000Z
diff --git a/packages/@ourworldindata/grapher/src/core/Grapher.tsx b/packages/@ourworldindata/grapher/src/core/Grapher.tsx
@@ -885,6 +885,8 @@ export class Grapher
     }
 
     @computed get chartSeriesNames(): SeriesName[] {
+        if (!this.isReady) return []
+
         // collect series names from all chart instances when faceted
         if (this.isFaceted) {
             const facetChartInstance = new FacetChart({ manager: this })

Original file line number	Diff line number	Diff line change
`@@ -885,6 +885,8 @@ export class Grapher`
`885`	`885`	`}`
`886`	`886`
`887`	`887`	`@computed get chartSeriesNames(): SeriesName[] {`
	`888`	`+ if (!this.isReady) return []`
	`889`	`+`
`888`	`890`	`// collect series names from all chart instances when faceted`
`889`	`891`	`if (this.isFaceted) {`
`890`	`892`	`const facetChartInstance = new FacetChart({ manager: this })`