Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking: issues with VSCode extension find-latest-etl-step #3374

Open
pabloarosado opened this issue Oct 7, 2024 · 2 comments
Open

Tracking: issues with VSCode extension find-latest-etl-step #3374

pabloarosado opened this issue Oct 7, 2024 · 2 comments
Labels

Comments

@pabloarosado
Copy link
Contributor

Add here any issues you find while using the VSCode extension find-latest-etl-step.

Known issues

  • It is not properly ignoring files from .gitignore. If you type, e.g. package you'll see that it lists files from .venv. For this reason, I had to hardcode ignoring certain folders, like data/. But there must be a way to properly take .gitignore into account (or even better, VSCode configuration, to also ignore archive folders).
  • It is slow. It takes a second (on my computer) to open. Maybe once files in .gitignore are excluded, it will be come faster.
@larsyencken larsyencken changed the title Issues with VSCode extension find-latest-etl-step Tracking: issues with VSCode extension find-latest-etl-step Oct 24, 2024
@Marigold
Copy link
Collaborator

Re-posting from here

Nice! I spent some time (actually, too much time...) trying to get searches like "meadow cherry" to work, but apparently, QuickPick doesn’t support fuzzy matching, and I couldn’t find a way to hack it. I think it should be possible to sort the results not just by date, but also by channel.

(It took me a while to figure out how to run the extension in development mode. If anyone wants to develop this further and hear about my experience, feel free to reach out.)

@pabloarosado
Copy link
Contributor Author

Nice! I spent some time (actually, too much time...) trying to get searches like "meadow cherry" to work, but apparently, QuickPick doesn’t support fuzzy matching, and I couldn’t find a way to hack it. I think it should be possible to sort the results not just by date, but also by channel.

Thanks @Marigold, I also tried making the "meadow cherry" case work, but I also gave up after a while. In any case, just typing "cherry", seeing the list of latest "cherry" steps, and moving or and down to find the meadow step, is better than our current situation (where we hit cmd+P, type "meadow cherry" and see multiple versions). I think it's easier to navigate channels than versions. Maybe sorting by channel could help, but I think currently it's alphabetical order, which puts garden first (which is what we need most of the time).

To me, the main issue with the extension is that it's a bit slow (~2-4 seconds to start). I thought the issue was that it's scanning too many things, even some that should be ignored (like gitignored folders and archives). But I didn't look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants